Bug 138744

Summary: Wish: dcraw 8.45 supports Pentax K10D
Product: [Applications] digikam Reporter: Paul Hunt <prhunt>
Component: Plugin-DImg-RAWAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles, lure
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In: 0.9.2
Sentry Crash Report:

Description Paul Hunt 2006-12-13 13:40:26 UTC
Version:            (using KDE KDE 3.5.1)
Installed from:    SuSE RPMs

Pentax K10D is a new and highly popular DSLR.  At user request, Dave Coffin has updated dcraw (v. 8.45) to support DNG and PEF for this camera.  Could digikam be updated with the current dcraw version?  THanks for considering!
Comment 1 caulier.gilles 2006-12-13 14:21:28 UTC
Hi Paul,

Since digiKam include dcraw source code in core, I have been waiting to see a similar report on B.K.O about dcraw update...

Well, i'm sorry but i cannot update this implementation until final release planed at Christmast. This is not my fault, but to dcraw author witch not preserve the dcraw command line options compatibility between dcraw release. If you look into dcraw changelog, you can see than between 8.41 and 8.42, the options "-s" has been completly changed :

- Support the Olympus E-400 and Sinar 4-shot files.
- Updated color matrices from DNG Converter 3.6.
- Changed "-s" option to support multi-shot cameras.

.. In fact the "-s" option from 8.41 version is :

«-s : Use secondary pixels (Fuji Super CCD SR only)»

.. and in 8.42 version :

«-s [0-99] : Select a different raw image from the same file»

Do you see the BIG problem ? Personally i think it's a shame. Imaging the incidence for all scripts and programs witch use dcraw tool... all is broken.

If i update dcraw implementation from digiKam core to last version, i need to update the RAW decoding settings widget, the RAW decoding workflow source code, the dcraw interface implementation, etc... And of course i need to do all regression tests again... 

To resume : give me an aspirin (:=)))

To have contacted Dave Coffin in the past about this subject (because it not the first time than dcraw command line options compatibility is broken), he have said than he will take a care about this problem... But in fact, i think he don't care...

Of course, dcraw decoder still an excelent program... I will update the implemetation later than 0.9.0-final release.

Nota : if you want to test digiKam with the most recent dcraw implementation, you have 2 ways :

- recompile yourself dcraw and rename "dcraw" program file to "digikamdcraw". Remplace the version of this program installed by digikam on your computer (usually in /usr/bin).
- if you compile youself digikam, just go to digikam/libs/dcraw and update the dcraw.c implementation. recompile and install digiKam

In both case, take a care. Nothing have been verified with dcraw version upper than 8.41 !

Gilles Caulier
Comment 2 Paul Hunt 2006-12-13 14:48:11 UTC
Hi Gilles,

On Wednesday 13 December 2006 23:21, Gilles Caulier wrote:
[bugs.kde.org quoted mail]
Many thanks for the rapid and comprehensive reply.

As I am going to compile the latest rc2, I think I will just experiment with 
the new dcraw as well.

In any case, I am not impatient!  In general, the open source community has 
responded far more quickly than their proprietary counterparts.

Thanks for supporting free and open source software.

Kind regards, Paul Hunt
Comment 3 Hubert Figuiere 2006-12-13 16:32:57 UTC
do you have a sample file a PEF files from the K10D?
Comment 4 Paul Hunt 2006-12-14 12:25:55 UTC
Hi Hubert,
>
> ------- Additional Comments From hfiguiere teaser fr  2006-12-13 16:32
> ------- do you have a sample file a PEF files from the K10D?


I have the camera so I can provide PEF and DNG samples.  THey would just be 
snap shots as I don't have colour charts or anything.

Where should I upload to?

Paul
Comment 5 caulier.gilles 2006-12-14 12:27:33 UTC
If you can, just post it like an attachment to this file.

Gilles
Comment 6 Hubert Figuiere 2006-12-14 16:03:50 UTC
The camera produce DNG as well?

Comment 7 Paul Hunt 2006-12-15 04:27:19 UTC
Camera produces PEF and DNG. I have samples (note these are NOT good photos!.

Files are too big to attach here (9mb and 16mb).  I'll try Yousendit.
Comment 8 caulier.gilles 2006-12-15 07:50:08 UTC
Paul,

About future Exiv2 library implementation, I'm very interessed too by :

- a PEF RAW file.
- a DNG RAW file.
- a JPEG file.

Please CC me files at "caulier dot gilles at kdemail dot net". Thanks in advance.

Gilles Caulier
Comment 9 Paul Hunt 2006-12-15 12:44:55 UTC
Hello Gilles,

On Friday 15 December 2006 16:50, Gilles Caulier wrote:
>
> About future Exiv2 library implementation, I'm very interessed too by :
>
> - a PEF RAW file.
> - a DNG RAW file.
> - a JPEG file.
>
> Please CC me files at "caulier dot gilles at kdemail dot net". Thanks in
> advance.
>
> Gilles Caulier


Gilles, I tried to attach samples, but the email bounced because the 
attachment was too big at about 20mb.

I am now trying www.yousendit.com - you should get an email providing a link 
from where you can download this file: pentax_k10d.tar.bz2

Please share these samples with interested team members - I think the 
www.yousendit.com will hold the file for a couple of days.

I will now be away for 1 week.  Please let me know if I can provide any 
further assistance.

Kind regards, Paul
Comment 10 Hubert Figuiere 2006-12-15 14:09:55 UTC
Gilles, can you share?
Comment 11 caulier.gilles 2006-12-15 16:07:42 UTC
Hubert,

http://digikam3rdparty.free.fr/misc.tarballs/pentax_k10d.tar.bz2

Gilles
Comment 12 Paul Hunt 2006-12-31 05:01:58 UTC
OK, did everyone who wanted them get the image samples?

Paul
Comment 13 caulier.gilles 2007-01-03 00:09:00 UTC
Yes, it's done Paul. thanks.

Gilles
Comment 14 caulier.gilles 2007-02-05 07:48:10 UTC
Luka,

Are you interressed by dcraw update in digiKam core ? It's a tiedous task todo ! (:=)))

Gilles

Comment 15 caulier.gilles 2007-03-05 22:34:12 UTC
SVN commit 639734 by cgilles:

digiKam from trunk : digiKam 0.9.2 implementation is started with a by change here (:=)) !!!

The first new feature is to add a depency to libkdcraw shared library to decode RAW pictures instead to use a dcraw part from digiKam core.
libkdcraw include dcraw 8.60 instead the old dcraw 8.41 from digiKam core. It support more recent camera RAW file formats and provide a new wavelet noise reduction filter.

If you want more informations about libkdcraw, take a look into my blog : http://www.digikam.org/?q=node/208

To packagers : please update your packages rules about this new depency 

BUG: 138744
CCBUGS: 142568

 M  +1 -0      README  
 M  +11 -0     configure.in.bot  
 M  +28 -0     configure.in.in  
 M  +1 -1      digikam/Makefile.am  
 M  +4 -1      digikam/albumfiletip.cpp  
 M  +5 -2      digikam/albumiconview.cpp  
 M  +4 -1      digikam/albumsettings.cpp  
 M  +7 -4      digikam/digikamapp.cpp  
 M  +4 -1      digikam/digikamview.cpp  
 M  +12 -1     digikam/main.cpp  
 M  +1 -2      kioslave/Makefile.am  
 M  +35 -23    kioslave/digikamalbums.cpp  
 M  +7 -4      kioslave/digikamthumbnail.cpp  
 M  +1 -1      libs/Makefile.am  
 M  +10 -10    libs/dimg/Makefile.am  
 M  +9 -6      libs/dimg/dimg.cpp  
 M  +6 -3      libs/dimg/dimg.h  
 M  +1 -1      libs/dimg/loaders/Makefile.am  
 M  +48 -360   libs/dimg/loaders/rawloader.cpp  
 M  +18 -52    libs/dimg/loaders/rawloader.h  
 M  +0 -167    libs/dimg/rawdecodingsettings.h  
 M  +2 -3      libs/dmetadata/Makefile.am  
 M  +7 -3      libs/dmetadata/dmetadata.cpp  
 M  +1 -1      libs/imageproperties/Makefile.am  
 M  +1 -1      libs/imageproperties/imagepropertiescolorstab.cpp  
 M  +4 -1      libs/imageproperties/imagepropertiestab.cpp  
 M  +1 -2      libs/threadimageio/Makefile.am  
 M  +5 -6      libs/threadimageio/loadingdescription.h  
 M  +5 -2      libs/threadimageio/previewtask.cpp  
 M  +1 -2      showfoto/Makefile.am  
 M  +1 -1      showfoto/setup/Makefile.am  
 M  +1 -1      showfoto/setup/setup.cpp  
 M  +9 -6      showfoto/showfoto.cpp  
 M  +1 -2      utilities/cameragui/Makefile.am  
 M  +4 -1      utilities/cameragui/cameraui.cpp  
 M  +5 -2      utilities/cameragui/umscamera.cpp  
 M  +1 -1      utilities/imageeditor/canvas/Makefile.am  
 M  +5 -2      utilities/imageeditor/canvas/iofilesettingscontainer.h  
 M  +1 -1      utilities/imageeditor/editor/Makefile.am  
 M  +6 -7      utilities/imageeditor/editor/editorwindow.cpp  
 M  +1 -2      utilities/setup/Makefile.am  
 M  +1 -1      utilities/setup/setup.cpp  
 M  +14 -12    utilities/setup/setupdcraw.cpp  
 M  +1 -1      utilities/setup/setupmime.cpp