Bug 138514

Summary:	No Content-Description or name for opengpg signatures
Product:	[Unmaintained] kmail	Reporter:	Chris Gagnon <thinkliberty>
Component:	general	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.9.5
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	pgp-name.patch

Description Chris Gagnon 2006-12-07 22:48:34 UTC

Version:           1.9.5 (using KDE KDE 3.5.5)
Installed from:    Compiled From Sources
Compiler:          g++ (GCC) 4.1.1 (Gentoo 4.1.1-r3)
 
OS:                Linux

Opengpg signatures have name or description so the attachment shows up as an unnamed dat file for email readers that do not support the openpgp mime type  

Evolution adds a file name and description to opengpg signatures. 

Example 

Evolution
<boundary flag here>
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

Kmail 
<boundary flag here>
Content-Type: application/pgp-signature

Comment 1 Philip Rodrigues 2006-12-08 14:55:55 UTC

I can confirm this. I've had a few people (Outlook users, I guess) ask me what the .dat file I attached was.

Comment 2 Chris Gagnon 2006-12-19 22:53:49 UTC

Created attachment 18983 [details]
pgp-name.patch

Patch for kdepim-3.5.5/kmail/messagecomposer.cpp to add a name and content
description of open-gpg signed messages. It's not pretty, but it works.

Comment 3 Allen Winter 2007-03-06 02:19:15 UTC

SVN commit 639771 by winterz:

fix bug "No Content-Description or name for opengpg signatures"
thanks for the patch Chris Gagnon.

BUGS: 138514


 M  +1 -1      messagecomposer.cpp  


--- branches/KDE/3.5/kdepim/kmail/messagecomposer.cpp #639770:639771
@@ -1066,7 +1066,7 @@
 static inline const char * nestedContentType( Kleo::CryptoMessageFormat f, bool signing ) {
   switch ( f ) {
   case Kleo::OpenPGPMIMEFormat:
-    return signing ? "application/pgp-signature" : "application/octet-stream" ;
+    return signing ? "application/pgp-signature; name=signature.asc \nContent-Description: This is a digitally signed message part." : "application/octet-stream" ;
   case Kleo::SMIMEFormat:
     if ( signing )
       return "application/pkcs7-signature; name=\"smime.p7s\"";