Bug 137912

Summary:	/tmp may not have enough space for magnatune plugin
Product:	[Applications] amarok	Reporter:	David Bremner <bremner-keyword-kde.673b66>
Component:	general	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.4.4
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	patch against magnatunealbumdownloader.cpp patch against magnatunealbumdownloader.h

Description David Bremner 2006-11-26 15:30:05 UTC

Version:           1.4.4 (using KDE 3.5.5, Debian Package 4:3.5.5a.dfsg.1-5 (4.0))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17

My /tmp is only 180M so downloading large zip files there does not work
very well; the download dies without giving me any error feedback.

amarok should check to make sure there is space in the temporary directory, and perhaps have a configurable download directory.

If nothing else, it seems more likely that there will be space for the temporary file where the user has just selected to download to.

Comment 1 David Bremner 2006-11-30 04:34:55 UTC

Created attachment 18727 [details]
patch against magnatunealbumdownloader.cpp

This, and the next attachment form give some idea of a patch. 
This crashes with today's SVN
Unfortunately it is a bit tricky for me to debug. I'm not sure I want to buy
that much music just now :-)

Comment 2 David Bremner 2006-11-30 04:36:49 UTC

Created attachment 18728 [details]
patch against magnatunealbumdownloader.h

Please note, these patches need debugging, and are posted only for 
discussion

Comment 3 Nikolaj Hald Nielsen 2006-12-05 18:04:14 UTC

I have committed your patch (with some changes, as it caused the album cover fetching and unpacking of downloaded albums to no longer work)

Marked as FIXED