Bug 137775

Summary:	add history for composer in playlist, too
Product:	[Applications] amarok	Reporter:	richlv
Component:	Playlist	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description richlv 2006-11-23 15:47:45 UTC

Version:           svn 606650 (using KDE KDE 3.5.4)
Installed from:    Slackware Packages
OS:                Linux

reported by gribouille
followup to bug 123026
composer field in tag editor now has nice history, but it does not in the playlist.

all other history-enabled fields work fine in the playlist, so it would be nice to be consistent with the composer fild, too.

Comment 1 Martin Aumueller 2006-11-28 22:08:40 UTC

SVN commit 608904 by aumuell:

complete composer when editing from playlist
BUG: 137775


 M  +2 -0      ChangeLog  
 M  +4 -0      src/playlist.cpp  


--- trunk/extragear/multimedia/amarok/ChangeLog #608903:608904
@@ -5,6 +5,8 @@
 
 VERSION 1.4.5
   FEATURES:
+    * Propose list of composers in collection when editing the composer tag
+      from the playlist. (BR 137775)
     * Greatly improved sound quality for the xine equalizer. Patch by Tobias
       Knieper <tobias.knieper@micekiller.de>. (BR 127307)
     * Fancy graphical volume slider for the OSD. Patch by Alexander Bechikov
--- trunk/extragear/multimedia/amarok/src/playlist.cpp #608903:608904
@@ -2215,6 +2215,10 @@
             renameLineEdit()->completionObject()->setItems( CollectionDB::instance()->genreList() );
             break;
 
+        case PlaylistItem::Composer:
+            renameLineEdit()->completionObject()->setItems( CollectionDB::instance()->composerList() );
+            break;
+
         default:
             renameLineEdit()->completionObject()->clear();
             break;

Comment 2 richlv 2006-11-30 15:18:42 UTC

fix confirmed in revision 609299