| Summary: | Invalid option added to smb.conf | ||
|---|---|---|---|
| Product: | [Unmaintained] kcontrol | Reporter: | Zé <mmodem00> |
| Component: | kcmsamba | Assignee: | Jan Schaefer <j_schaef> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Comments out msdfs proxy
The patch to fix the problem |
||
|
Description
Zé
2006-11-19 16:03:13 UTC
The line msdfs proxy = no is invalid. The module should not add it. smb.conf(5) says it's a value option, not a yes/no one. After checking again i saw that after removing only the line msdfs proxy = no from /etc/samba/smb.conf the share starts being correctly mounted, so is this line that is stopping a share from being mounted, and this line is added after running kcontrol and entering Internet & Network->File sharing, edit a share,then click the button "More Samba Options" and clicking the tab "security". Anyway if the user just edit a share and doesnt make any change it should NEVER add any modification to smb.conf like is wrongly happening now. So in resume when entering in kcontrol->"Internet & Network"->"File sharing" and then editing a share and clicking in button "More Samba Options" and going through the severall tabs, it adds these 3 lines: case sensitive = no strict locking = no msdfs proxy = no in wich the line "msdfs proxy = no" is invalid, it causes that the share cant be mounted with the message: "Details 4763: tree conect failed: ERRDOS _ ERRnosuchshare (You specified an invalid share) SMB conection failed" Created attachment 20556 [details]
Comments out msdfs proxy
This patch fixes the msdfs proxy = no entry being added to the /etc/samba/smb.conf file for shares created through the kde control center. I can confirm this bug affects Debian lenny too. Is somebody going to fix this? It is very annoying as it basically renders the kcontrol samba modules useless. See also: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/95452 This bug is pestering Feisty for a long time also: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/95460 Created attachment 21035 [details]
The patch to fix the problem
Basically, msdfs proxy is a string not a boolean. So I just changed the type of
corresponding configure option.
Finaly passed almost a year since the bug report was created, it finallt gets fixed... just great... This patch isnt comited in branch_3.5 I am sorry, but the bug has been assigned to the wrong developer. Alexander is not responsible for this, but me. He should have assigned the bug to me, but he was very busy with other important things so he propably just overlooked this. Nevertheless I will now finally commit the patch. SVN commit 755533 by schafer: Fixed the widgets of the following samba options: case sensitive, strict locking, msdfs proxy The wrong widgets resulted in wrong default values, which in turn resulted in wrongly generated settings in the smb.conf file. BUG: 137577 M +643 -378 share.ui M +5 -3 sharedlgimpl.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=755533 |