Summary: | Don't close channel tabs on non-user-induced PART | ||
---|---|---|---|
Product: | [Applications] konversation | Reporter: | Stephanie Daugherty <stephanie> |
Component: | general | Assignee: | Konversation Developers <konversation-devel> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | reg |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Stephanie Daugherty
2006-11-09 05:48:36 UTC
*** Bug 139715 has been marked as a duplicate of this bug. *** Yup, that is really annoying strange behaviour, and half a year without resolving... I'm taking a renewed interest in this one. Renamed for clarity. First of, the opening statement of the report is no longer true; losing connection to the server doesn't result in the views being closed. It's been that way for a while now. That creates an actual propblem, however, in that it makes the behavior inconsistent between connection loss and other reasons for a channel being PARTed by other means than a manual close, e.g. a kick. That's not good enough; it should either close every time, or stay open in both scenarios. If we opt for the latter, the challenge becomes giving clear and hard-to-miss indication that a channel is not joined despite the view being open. We currently wipe a channel's nickname list on loss of connection, and the same should be done when keeping it open after a kick. Additionally, we need to make sure that an appropriate message always ends up being in that view, and at the end of the buffer. Furthermore, greying out the tab label might be nice to do, and showing a Rejoin action in the tab context menu. SVN commit 797886 by argonel: prevent channel from closing when kicked, can rejoin with tab context menu or /join. BUG:137074 M +47 -18 channel.cpp M +4 -2 channel.h M +1 -1 commit.h M +2 -0 konversationmainwindow.cpp M +14 -15 outputfilter.cpp M +1 -1 server.cpp M +44 -1 viewcontainer.cpp M +1 -0 viewcontainer.h WebSVN link: http://websvn.kde.org/?view=rev&revision=797886 |