| Summary: | kmines Makefile has bashism | ||
|---|---|---|---|
| Product: | [Applications] kmines | Reporter: | alancio <lameventanas> |
| Component: | general | Assignee: | Dmitry Suzdalev <dimsuz> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | finex |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Fixes to kmines, kfouleggs, klickety and ksirtet Makefiles | ||
Created attachment 19437 [details]
Fixes to kmines, kfouleggs, klickety and ksirtet Makefiles
Apply the patch as follows:
patch -p1 < /var/tmp/kdegames-sh.patch
automake
perl admin/am_edit
Then run configure, make, make install as usual.
By the way, I made this patch for kdegames 3.5.6, but it must work for 3.5.5 too, let me know. The patch seems wrong, if i apply it i get Error: Could not install the game with correct permissions !! Error: Could not create the highscore directory with correct permissions !! Error: Could not install the game with correct permissions !! Error: Could not install the game with correct permissions !! Error: Could not create system-wide highscore file with correct permissions !! Which does not happen if i do not apply it. Albert, I'm sure you got the same messages without applying the patch, but you just didn't notice them. This patch is to solve the bashisms in the makefiles, if you want correct system permissions you have to be root. kmines compiles right on current trunk. |
Version: (using KDE KDE 3.5.5) Installed from: Compiled From Sources OS: Linux If you are not using bash as your /bin/sh, kmines building process fails with the following errors: make[2]: Entering directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines' make[3]: Entering directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines' test -z "/usr/bin" || mkdir -p -- "/usr/ports/work/kdegames/pkg/usr/bin" /bin/sh ../libtool --silent --mode=install /usr/bin/install -c -p 'kmines' '/usr/ports/work/kdegames/pkg/usr/bin/kmines' make install-exec-hook make[4]: Entering directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines' /bin/sh: syntax error: '(' unmatched make[4]: *** [install-exec-hook] Error 1 make[4]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines' make[3]: *** [install-exec-am] Error 2 make[3]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines' make[2]: *** [install-am] Error 2 make[2]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines' make[1]: *** [install-recursive] Error 1 make[1]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines' make: *** [install-recursive] Error 1