Summary: | <ctrl>+mouse copying broken | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Richard Bos <richard.bos> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aacid |
Priority: | NOR | ||
Version: | 1.6.5 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8 | |
Attachments: | join lines by using SPACE as delimiter |
Description
Richard Bos
2006-11-02 21:03:22 UTC
Sorry I hit the <enter> button while editing the title :( Can somebody update the title to: <ctrl>+mouse copying broken TIA It works for me with a previous konsole version (1.6.4) This one is running on suse-10.0 While I found the bug on suse-10.1 konsole-1.6.5 Confirmed that this feature is not present in KDE 4.x Hi Robert, the functionality is almost(!) there. At the moment every copied line is just pasted after eachother, without spacing. Now if the space would be there the functionality would be back again. The current behaviour is probably better understood with an example: Execute: kde@eos:~> echo "This is a copy and paste test" Copy the resulting text of the command above with the <ctrl> key pressed. Pasting with the MMB results in: Thisisa copy andpastetest If there would be space at the former NEWLINE positions, this bug could be closed! Created attachment 61900 [details] join lines by using SPACE as delimiter (In reply to comment #4) > the functionality is almost(!) there. You are right :D This simple patch should make it work as your expectation. It puts a SPACE between joined lines, instead of joining them seamlessly. Git commit 4f8da80fec79b8d229bfb75d5825b65a3f4bea61 by Kurt Hindenburg. Committed on 24/07/2011 at 22:22. Pushed by hindenburg into branch 'master'. Use SPACE as delimiter when joining multiple lines. Currently, when users use ctrl+mouse to select and copy multiple lines, those lines are joined into single line in a seamless way. LINEBREAK is simply removed, thus the first character of second line will be positioned right after the last character of the first line. This patch replaces the LINEBREAK with a SPACE. Thanks to Jekyll Wu (adaptee@gmail.com) for patch and research. BUG: 136730 FIXED-IN: 4.8 M +5 -2 src/Screen.cpp http://commits.kde.org/konsole/4f8da80fec79b8d229bfb75d5825b65a3f4bea61 I do not know what is the point of this, but it totally breaks copying text from konsole, adding a space where there is none seems like a totally bad idea to me. Ben from the sysadmin team for example complains now all the ssh key hashes he copies get a space added in the middle. #7, Ben and you are using Ctrl+mouse to select text? or did this patch break normal copy/paste? No, we use left click mouse to select the text and then use ctrl+shift+c to copy it. Jekyll, do you have time to look at this? If you copy a really long line (past your width) and paste it, there are spaces in it. Example (assuming your screen width is less than that) aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa paste will have spaces at the screen width. Git commit 4dd68c4c5bebbe277595445409533f3265277285 by Jekyll Wu. Committed on 14/08/2011 at 23:44. Pushed by jekyllwu into branch 'master'. Do not append extra space when copying wrapped lines. This is a fix for the regression caused by commit 4f8da8. BUG: 136730 M +12 -9 src/Screen.cpp http://commits.kde.org/konsole/4dd68c4c5bebbe277595445409533f3265277285 |