Bug 136294

Summary: Amarok dialog doesn't honor "No" and still runs script
Product: [Applications] amarok Reporter: Juan Carlos Torres <carlosdgtorres>
Component: generalAssignee: Amarok Bugs <amarok-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Juan Carlos Torres 2006-10-25 15:02:30 UTC 
Version:            (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages
OS:                Linux

Kubuntu 6.10 (Edgy) has a new script for Amarok that installs MP3 Support. When you try to play an MP3 in Amarok, a dialog box will popup, asking whether you want to install MP3 support. Clicking on "Yes" will run the script. However, clicking on "No" will also run the script.

Amarok 1.4.3
KDE 3.5.5
Kubuntu 6.10 (Edgy)
Comment 1 Alexandre Oliveira 2006-10-27 22:34:44 UTC 
SVN commit 599609 by aoliveira:

Ok, I don't know who would want to say No to this dialog, but in case it happens, let's respect it.
BUG: 136294


 M  +2 -0      ChangeLog  
 M  +1 -1      src/enginecontroller.cpp  


--- trunk/extragear/multimedia/amarok/ChangeLog #599608:599609
@@ -9,6 +9,8 @@
   CHANGES:
 
   BUGFIXES:
+    * The Install MP3 support script would be run regardless of what the
+      user answered to the shown dialog. (BR 136294)
     * OSD wouldn't always show up-to-date ratings. Patch by Tuomas Nurmi
       <tnurmi@edu.kauhajoki.fi>. (BR 125612)
 
--- trunk/extragear/multimedia/amarok/src/enginecontroller.cpp #599608:599609
@@ -272,7 +272,7 @@
             , i18n( "No MP3 Support" )
             , installButton
             , KStdGuiItem::no()
-            , "codecInstallWarning" )  )
+            , "codecInstallWarning" ) == KMessageBox::Yes )
             {
                     KRun::runCommand(installScript);
                     return true;