Bug 135437

Summary:	Text view object justification not working
Product:	[Applications] kst	Reporter:	Nicolas Brisset <nicolas.brisset>
Component:	general	Assignee:	kst
Status:	RESOLVED NOT A BUG
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	unspecified
OS:	Solaris
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Nicolas Brisset 2006-10-11 09:01:09 UTC

Version:           1.3.1_devel (using KDE 3.4.0, compiled sources)
Compiler:          gcc version 3.4.3
OS:                SunOS (sun4u) release 5.8

This is certainly related with changes made at some point to have label boxes fit to their contents unconditionally, but the text view object dialog still contains options that no longer have any effect: 
- vertical justification (it can't have any effect since the box adapts its height to the contents, but then why keep it around ?)
- horizontal justification: that one should work but if you type text over two lines and select horizontal justification you will notice that lines remain left-centered.

Comment 1 Netterfield 2006-11-25 04:04:44 UTC

Vertical Justification has been removed from the dialog.
Horizontal is still in the UI, but it currently doesn't do anything.
It will require work on the label renderer to make it work.  This should either be done, or horizontal justification removed from the UI before the next release.

Comment 2 Andrew Walker 2007-01-06 00:33:22 UTC

SVN commit 620422 by arwalker:

BUG:135437 Remove the horizontal justifcation item as it is non-functional given the new behaviour for labels.

 M  +0 -4      kstviewlabel.cpp  
 M  +101 -66   viewlabelwidget.ui  
 M  +0 -3      viewlabelwidget.ui.h

Comment 3 Andrew Walker 2007-01-23 21:16:10 UTC

Fix was reverted so bug report should be reopened.

Comment 4 Andrew Walker 2007-01-26 01:46:16 UTC

Note added by staikos when reverting previous fix
===================
revert 620422 - put horizontal justification options back in, though they don't
work because auto-resize of labels is now mandatory.  problems with this are
pointed out on the list.  Let's solve the problems in entirety.

Comment 5 Netterfield 2007-02-19 15:39:47 UTC

SVN commit 635238 by netterfield:

Hide, but do not remove the horizontal justification UI until
such time as it is implemented.

CCBUG: 135437



 M  +3 -0      viewlabelwidget.ui.h  


--- trunk/extragear/graphics/kst/src/libkstapp/viewlabelwidget.ui.h #635237:635238
@@ -19,6 +19,9 @@
     _horizontal->insertItem(i18n("Right"));
     _horizontal->insertItem(i18n("Center"));
 
+    _horizontal->hide();// FIXME: until implemented - bug 135437
+    textLabel5_3->hide();
+
     connect(_strings, SIGNAL(selectionChanged(const QString &)),
 	    this, SLOT(insertStringInText(const QString &)));

Comment 6 Andrew Walker 2007-04-13 01:58:38 UTC

Text view object justification has been hidden and will be un-hidden when (and if) the necessary functionality is added.