Bug 135395

Summary:	konqueror crashes if I try to edit the filename when overwriting a .part file
Product:	[Applications] konqueror	Reporter:	Chris Moore <dooglus>
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED WORKSFORME
Severity:	crash	CC:	faure, finex, lex.lists
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Chris Moore 2006-10-10 15:20:24 UTC

Version:            (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages
OS:                Linux

1. visit http://dooglus.rincevent.net/random/download.htm - this is just a simple page with a link to a file full of full stops called 'download.bug' 
2. click the link
3. click 'save as'
4. click 'save'
5. quickly click 'cancel' before the download completes
6. click the link again
7. click 'save as' again
8. click 'save' again

a dialog will appear saying "A similar file named '/home/...download.bug' already exists.", and I'll be offered the chance to edit the name I'm saving as.

If I try editing the name, konqueror crashes.

Notice that the dialog's text isn't accurate - it tells me that a file called "download.bug" already exists, whereas in fact it doesn't.  "download.bug.part" exists, not "download.bug".  I don't know if this error is related to the error which causes the crash.

Comment 1 Chris Moore 2006-10-10 15:40:21 UTC

This was on debian unstable, not debian testing as it claims in the original report.  I selected 'testing/unstable' when reporting the bug.

Comment 2 lexual 2006-10-13 14:28:37 UTC

confirming for 3.5.5

Comment 3 Tommi Tervo 2007-07-10 14:17:39 UTC

#6  0xb7a68ae4 in KIO::RenameDlg::enableRenameButton (this=0xbff29008, 
    newDest=@0x8fc1798)
    at /root/kdelibs/kdelibs-3.5.7/./kio/kio/renamedlg.cpp:396
#7  0xb7a8fa54 in KIO::RenameDlg::qt_invoke (this=0xbff29008, _id=60, 
    _o=0xbff28408) at ./renamedlg.moc:112
#8  0xb71f888b in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#9  0xb71f8dc0 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#10 0xb75985af in QLineEdit::textChanged () from /usr/lib/libqt-mt.so.3
#11 0xb72d94a8 in QLineEditPrivate::finishChange ()
   from /usr/lib/libqt-mt.so.3
#12 0xb72d9d20 in QLineEdit::insert () from /usr/lib/libqt-mt.so.3
#13 0xb72da73f in QLineEdit::keyPressEvent () from /usr/lib/libqt-mt.so.3
#14 0xb722f87f in QWidget::event () from /usr/lib/libqt-mt.so.3
#15 0xb72d9b4b in QLineEdit::event () from /usr/lib/libqt-mt.so.3
#16 0xb718fa60 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#17 0xb7191a30 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#18 0xb7897c32 in KApplication::notify (this=0xbff2a078, receiver=0x9baf5c0, 
    event=0xbff289c4)
    at /root/kdelibs/kdelibs-3.5.7/./kdecore/kapplication.cpp:550
#19 0xb712225d in QApplication::sendSpontaneousEvent ()
   from /usr/lib/libqt-mt.so.3
#20 0xb7112c49 in QETWidget::translateKeyEvent () from /usr/lib/libqt-mt.so.3
#21 0xb711f02f in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
#22 0xb7136180 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#23 0xb71aa136 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#24 0xb7191587 in QApplication::enter_loop () from /usr/lib/libqt-mt.so.3
#25 0xb73ad3e9 in QDialog::exec () from /usr/lib/libqt-mt.so.3
#26 0xb7a8522c in KIO::open_RenameDlg (_caption=@0xbff291e0, 
    _src=@0xbff291dc, _dest=@0xbff291d8, _mode=97, _new=@0xbff291d4, 
    sizeSrc=18446744073709551615, sizeDest=16076800, ctimeSrc=-1, 
    ctimeDest=-1, mtimeSrc=-1, mtimeDest=-1)
    at /root/kdelibs/kdelibs-3.5.7/./kio/kio/renamedlg.cpp:563
#27 0xb7a8537a in Observer::open_RenameDlg (this=0x89e6518, job=0x8cd6330, 
    caption=@0xbff291e0, src=@0xbff291dc, dest=@0xbff291d8, mode=97, 
    newDest=@0xbff291d4, sizeSrc=18446744073709551615, sizeDest=16076800, 
    ctimeSrc=-1, ctimeDest=-1, mtimeSrc=-1, mtimeDest=-1)
    at /root/kdelibs/kdelibs-3.5.7/./kio/kio/observer.cpp:393
#28 0xb7ab2e51 in KIO::FileCopyJob::slotCanResume (this=0x93feb20, 
    job=0x891e690, offset=16076800)
    at /root/kdelibs/kdelibs-3.5.7/./kio/kio/job.cpp:1765
#29 0xb7ab3347 in KIO::FileCopyJob::qt_invoke (this=0x93feb20, _id=14, 
    _o=0xbff292bc) at ./jobclasses.moc:1591
#30 0xb71f888b in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#31 0xb7a52ce0 in KIO::TransferJob::canResume (this=0x891e690, t0=0x891e690, 
    t1=16076800) at ./jobclasses.moc:1064
#32 0xb7a52d4f in KIO::TransferJob::slotCanResume (this=0x891e690, offset=0)
    at /root/kdelibs/kdelibs-3.5.7/./kio/kio/job.cpp:1195
#33 0xb7a928c7 in KIO::TransferJob::qt_invoke (this=0x891e690, _id=25, 
    _o=0xbff293c0) at ./jobclasses.moc:1079
#34 0xb71f888b in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#35 0xb7a51ad1 in KIO::SlaveInterface::canResume (this=0x920c078, t0=16076800)
    at ./slaveinterface.moc:293
#36 0xb7abd065 in KIO::SlaveInterface::dispatch (this=0x920c078,

Comment 4 FiNeX 2008-05-20 21:17:22 UTC

Cannot confirm on 3.5.9 and 4.

Comment 5 Rui G. 2008-05-20 21:57:47 UTC

Cannot confirm on 3.5.9 and svn trunk r808114

Comment 6 David Faure 2008-11-27 17:11:30 UTC

Strange, I just had this crash with KDE 4.1.3, and it was fixed by r889749.
I kind of doubt that it was really fixed before that (the code was unchanged from kde3). Anyway, now it's fixed ;)

Comment 7 David Faure 2008-11-27 17:17:49 UTC

SVN commit 889786 by dfaure:

Backport 889749+889785: fix for crash 135395 (closed long ago by mistake),
by hiding the lineedit when M_NORENAME is set. Testcase: resuming aborted download.
CCBUG: 135395


 M  +5 -2      renamedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=889786