Bug 135343

Summary:	Plugin output vectors have no name
Product:	[Applications] kst	Reporter:	Nicolas Brisset <nicolas.brisset>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.x
Target Milestone:	---
Platform:	unspecified
OS:	Solaris
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Nicolas Brisset 2006-10-09 15:27:47 UTC

Version:           1.3.1_devel (using KDE 3.4.0, compiled sources)
Compiler:          gcc version 3.4.3
OS:                SunOS (sun4u) release 5.8

The vectors generated by plugins no longer have names. It is certainly a very minor problem, and if so should be fixed for 1.3.1 in my opinion...

To reproduce:
1) start kst, load column 1 from gyrodata.dat
2) launch the data manager, create a new plugin, e.g. "shift"
3) select "1" as the X vector, and leave the default skip value to 10
4) hit "OK": a new vector is created, called "Anonymous Vector 1". It used to have a more meaningful name... What's worse: if you take care to provide an output vector name, it is ignored.

Comment 1 Adam Treat 2006-10-09 17:08:35 UTC

On Monday 09 October 2006 9:27 am, Nicolas Brisset wrote:
[bugs.kde.org quoted mail]

What more meaningful name did it used to have?

Comment 2 Nicolas Brisset 2006-10-09 18:14:38 UTC

The default name used to be something like [pluginname]-[OutputName] with possibly some extra sequence to make the name unique. I'm not saying that's great, but it contains useful information. 
In any case, if you mention a name explictly in the lineedit of the output vector it should be used...

Comment 3 Netterfield 2006-10-10 04:47:28 UTC

On Monday 09 October 2006 09:27, Nicolas Brisset wrote:
> ... What's worse: if you take care to provide an output vector name, it is 

ignored.

This is particularly annoying.... and a clear bug.

Comment 4 Netterfield 2006-10-12 16:48:47 UTC

SVN commit 594845 by netterfield:

BUG: 135343

Nicolas seems correct: the fix was trivial (though surprising that it
was missing).  Basically, the name was generated , but never used (?).
This should be back-ported to 1.3 - hopefully 1.3.1.

This code could use some re-arranging, but not for 1.3.




 M  +7 -0      kstplugindialog_i.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kstplugindialog_i.cpp #594844:594845
@@ -497,6 +497,7 @@
           plugin->outputVectors().insert((*it)._name, v);
           KST::addVectorToList(v);
         }
+        v->setTagName(nt);
       } else if (plugin->outputVectors()[(*it)._name]->tagName() != nt) {
         while (KstData::self()->vectorTagNameNotUnique(nt, false)) {
           nt += "'";
@@ -510,6 +511,7 @@
           plugin->outputVectors().insert((*it)._name, v);
           KST::addVectorToList(v);
         }
+        v->setTagName(nt);
       }
     } else if ((*it)._type == Plugin::Data::IOValue::StringType) {
       if (!KstData::self()->vectorTagNameNotUnique(nt, false)) {
@@ -521,6 +523,8 @@
           s->writeLock();
           plugin->outputStrings().insert((*it)._name, s);
         }
+        s->setTagName(nt);
+
       } else if (plugin->outputStrings()[(*it)._name]->tagName() != nt) {
         while (KstData::self()->vectorTagNameNotUnique(nt, false)) {
           nt += "'";
@@ -533,6 +537,7 @@
           s->writeLock();
           plugin->outputStrings().insert((*it)._name, s);
         }
+        s->setTagName(nt);
       }
     } else if ((*it)._type == Plugin::Data::IOValue::PidType) {
       // Nothing
@@ -546,6 +551,7 @@
           s->writeLock();
           plugin->outputScalars().insert((*it)._name, s);
         }
+        s->setTagName(nt);
       } else if (plugin->outputScalars()[(*it)._name]->tagName() != nt) {
         while (KstData::self()->vectorTagNameNotUnique(nt, false)) {
           nt += "'";
@@ -558,6 +564,7 @@
           s->writeLock();
           plugin->outputScalars().insert((*it)._name, s);
         }
+        s->setTagName(nt);
       }
     }
   }