Bug 134924

Summary: Patch to allow compile with LDFLAGS="-Wl,--as-needed"
Product: [Applications] digikam Reporter: David Philippi <david>
Component: Portability-CompilationAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: rdieter
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 0.9.0
Sentry Crash Report:
Attachments: The actual patch

Description David Philippi 2006-09-30 22:51:23 UTC 
Version:           0.9.0_beta2 (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages
OS:                Linux

I'm using Gentoo and have LDFLAGS="-Wl,--as-needed" activated globablly. Unfortunately digikam didn't compile with it because in digikam/showfoto/Makefile.am the libs are in wrong order. The attached patch fixes the problem without any invasive change.
Comment 1 David Philippi 2006-09-30 22:53:09 UTC 
Created attachment 17974 [details]
The actual patch
Comment 2 Rex Dieter 2006-10-01 00:59:24 UTC 
Doesn't
./configure --enable-new-ldflags
work for this?
Comment 3 caulier.gilles 2006-10-01 19:59:51 UTC 
SVN commit 591098 by cgilles:

digikam from trunk : fix broken compilation under Gentoo.
BUG: 134924

 M  +4 -4      Makefile.am  


--- trunk/extragear/graphics/digikam/showfoto/Makefile.am #591097:591098
@@ -22,9 +22,7 @@
 
 showfoto_SOURCES = main.cpp showfoto.cpp 
 
-showfoto_LDADD   = $(LIB_QT) $(LIB_KDECORE) $(LIB_KDEUI) $(LIB_KUTILS) \
-		   $(LIB_KFILE) $(LIB_KPARTS) $(LIBJPEG) $(LIB_EXIV2) \
-		   $(top_builddir)/digikam/showfoto/setup/libsetup.la \
+showfoto_LDADD   = $(top_builddir)/digikam/showfoto/setup/libsetup.la \
 		   $(top_builddir)/digikam/libs/widgets/libwidgets.la \
 		   $(top_builddir)/digikam/libs/dialogs/libdialog.la \
 		   $(top_builddir)/digikam/libs/imageproperties/libimagepropertiesshowfoto.la \
@@ -33,7 +31,9 @@
 		   $(top_builddir)/digikam/utilities/imageeditor/editor/libdimgeditor.la \
 		   $(top_builddir)/digikam/utilities/imageeditor/editor/libshowfoto.la \
 		   $(top_builddir)/digikam/utilities/splashscreen/libsplashscreen.la \
-		   $(top_builddir)/digikam/libs/threadimageio/libthreadimageio.la
+		   $(top_builddir)/digikam/libs/threadimageio/libthreadimageio.la \
+		   $(LIB_QT) $(LIB_KDECORE) $(LIB_KDEUI) $(LIB_KUTILS) \
+		   $(LIB_KFILE) $(LIB_KPARTS) $(LIBJPEG) $(LIB_EXIV2) 
 
 showfoto_LDFLAGS = $(KDE_RPATH) $(all_libraries)