Bug 134555

Summary:	bug 121449 split -- Customization dialog has focus problems
Product:	[Unmaintained] kdelibs	Reporter:	Mats Ahlgren <ahlgren>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andresbajotierra, finex
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Proposed patch

Description Mats Ahlgren 2006-09-23 20:00:40 UTC

Version:           3.5.2 (using KDE 3.5.2, Kubuntu Package 4:3.5.2-0ubuntu18.1 dapper)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-26-686

By request of someone who invalidated bug 121449 and was too lazy to split the bug up himself, I'm splitting up bug 121449. Here's one part below.

Because I was forced to do this, I'm not checking for duplicity. If you find duplicity though, consider that these reports may contain more information than the duplicates, and were also filed before on Feb 6, 2006.

Seriousness: This bug was found within 5 minutes of trying out Konqueror for the first time.

___ BEGIN bug 121449 SUBPART ___


===== Miscellaneous
12) The Toolbar Customization dialog has a problem with keeping track of focus. For example, set up your main toolbar list so you have more than 3 elements, then click on an element somewhere in the center. Then, add two more elements from the left side of the dialog box. The first element you add will be right below the middle element you clicked on (in the middle of the toolbar), but the next element you add will be at the bottom of the list (at the end of the toolbar). This is wrong: the second element you added should be added after the first element you added.

Comment 1 FiNeX 2008-06-01 18:51:13 UTC

Confirmed in KDE 3.5.9 and KDE 4.
Changed product from konqueror to kdelibs.

Comment 2 Dario Andres 2009-05-01 22:37:59 UTC

Here using:

Qt: 4.5.1 (qt-copy  958974)
KDE: 4.2.71 (KDE 4.2.71 (KDE 4.3 >= 20090428))
kdelibs svn rev. 960693 / kdebase svn rev. 960693
on ArchLinux i686 - Kernel 2.6.29.1

I can also reproduce this. 
The problem is, when moving from "Available" to "Current", the internal XML list needs to be rewritten and therefore the "Current" list is cleared and reloaded. So the focus is lost

Comment 3 Dario Andres 2009-05-01 23:06:24 UTC

Created attachment 33285 [details]
Proposed patch

This is the easier way to fix this without touching the code too much.

Comment 4 Dario Andres 2009-05-02 00:12:57 UTC

SVN commit 962271 by darioandres:

When moving an action from Available to Current, set the focus on the new added option
So, if the user adds more actions they will be place under the first added on.
(instead of putting them at the bottom)

BUG: 134555


 M  +20 -1     kedittoolbar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=962271

Comment 5 Dario Andres 2009-05-02 00:16:52 UTC

SVN commit 962273 by darioandres:

Backport to 4.2branch of:
SVN commit 962271 by darioandres:

When moving an action from Available to Current, set the focus on the new added
option
So, if the user adds more actions they will be place under the first added on.
(instead of putting them at the bottom)

CCBUG: 134555


 M  +20 -1     kedittoolbar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=962273