Bug 133955

Summary: rating search: less, equal, and larger comparison
Product: [Applications] digikam Reporter: Arnd Baecker <arnd.baecker>
Component: Searches-LabelsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Debian stable   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 0.9.1
Sentry Crash Report:
Attachments: patch for rating search

Description Arnd Baecker 2006-09-12 13:25:17 UTC 
Version:            (using KDE KDE 3.4.2KDE 1.2)
Installed from:    Debian stable PackagesDebian stable Packages
OS:                Linux

Doing an Advanced Search for
"Rating" "Higher than" "******"
will not produce any results as presently 5 is the maximum.

This could be solved (and enhanced) by ">=",  "="  and "<=" as possible choices in the comparison.

Arnd
Comment 1 Arnd Baecker 2007-01-04 10:57:08 UTC 
Attached is a patch which should solve this issue.
In addition it provides "<=" and ">="
(which were essentially already present in the source (for ">" and "<"),
but RuleOpTableCount did not match with the number of items.
Adding ">=" required to add GTE and LTE, also in 
the kioslave/digikamsearch part.

Best, Arnd
Comment 2 Arnd Baecker 2007-01-04 10:58:03 UTC 
Created attachment 19098 [details]
patch for rating search
Comment 3 caulier.gilles 2007-01-04 11:22:39 UTC 
Arn,

Thanks for the patch. Really appreciate !

Marcel, the patch sound fine for me. What do you think about ?

Gilles
Comment 4 Marcel Wiesweg 2007-01-04 12:37:57 UTC 
Yes it seems fine to me.
Comment 5 caulier.gilles 2007-01-04 13:09:00 UTC 
SVN commit 619777 by cgilles:

digiKam from trunk : patch from Arnd Baecker to use less, equal, and larger comparison with rating search in image collection.
BUG: 133955



 M  +12 -23    digikam/searchwidgets.cpp  
 M  +3 -4      digikam/searchwidgets.h  
 M  +189 -160  kioslave/digikamsearch.cpp  
 M  +16 -11    kioslave/digikamsearch.h