Bug 133506

So this message gets shown if the torrent hasn't reached it's max share ratio ?

Crap, I forgot to test this.

Ignore my previous comment.

Anyway we could split the completed state to :
Seeding Completed
Download Completed

Or something similar. 

No the message on itself works fine is good to have too. The thing why i mentioned it is: the message says that a torrent is now stopped because it has the correct ratio. While doing so, the status on the torrent goes to to "completed". Nothing wrong here i think.
 
But people might learn from the popup and link the status completed to completed AND ratio completed, where in case you stop a seed which isn't ratio completed, it gets the same status. This is where i think a status the same as when stopping a download by hand, stopped, would be better.

Hmm, after thinking about it, i finally understand your post. Sorry about that ;)
I like your idea more than mine.

So instead of
Not started <-> downloading <-> stalled <-> stopped
Not started <-> seeding <-> completed (which is manually stopped now)

It would be?
Not started <-> downloading <-> stalled <-> stopped
Not started <-> seeding <-> Download completed or Seeding completed (after manually stopped)

Yeah i like that, i think it would make it easier to read. :)
Thanks for being so pragmatic.

Off course
Download completed or Seeding completed (after manually stopped) 
should be
Download completed (after manually stopped) or Seeding completed

Hmm, should we make a poll on the forum between this proposed system and what we now?

I open for suggestions

Of course, i understand. :)
  

SVN commit 592062 by guisson:

Added distinction in Completed status, there is now a seeding completed and a downloading completed. Seeding completed means that the torrent has reached it's max share ratio.

BUG: 133506 



 M  +2 -1      apps/ktorrent/ktorrentviewitem.cpp  
 M  +2 -1      apps/ktorrent/queuedialog.cpp  
 M  +2 -1      libktorrent/interfaces/torrentinterface.h  
 M  +7 -3      libktorrent/torrent/torrentcontrol.cpp  


--- trunk/extragear/network/ktorrent/apps/ktorrent/ktorrentviewitem.cpp #592061:592062
@@ -62,7 +62,8 @@
 	{
 		case kt::SEEDING :
 		case kt::DOWNLOADING:
-		case kt::COMPLETE :
+		case kt::DOWNLOAD_COMPLETE :
+		case kt::SEEDING_COMPLETE :
 		case kt::ALLOCATING_DISKSPACE :
 			return green;
 		case kt::STALLED:
--- trunk/extragear/network/ktorrent/apps/ktorrent/queuedialog.cpp #592061:592062
@@ -125,7 +125,8 @@
 		TorrentInterface* tc = *it;
 		TorrentStatus ts = tc->getStats().status;
 		
-		if(ts == kt::SEEDING || ts == kt::COMPLETE || tc->getStats().completed)
+		if(ts == kt::SEEDING || ts == kt::DOWNLOAD_COMPLETE || 
+			ts == kt::SEEDING_COMPLETE || tc->getStats().completed)
 		{
 			QueueItem* item = new QueueItem(tc, seedList);
 			seedList->insertItem(item);
--- trunk/extragear/network/ktorrent/libktorrent/interfaces/torrentinterface.h #592061:592062
@@ -45,7 +45,8 @@
 	enum TorrentStatus
 	{
 		NOT_STARTED,
-		COMPLETE,
+		SEEDING_COMPLETE,
+		DOWNLOAD_COMPLETE,
 		SEEDING,
 		DOWNLOADING,
 		STALLED,
--- trunk/extragear/network/ktorrent/libktorrent/torrent/torrentcontrol.cpp #592061:592062
@@ -795,8 +795,10 @@
 			stats.status = kt::NOT_STARTED;
 		else if(!stats.running && !stats.user_controlled)
 			stats.status = kt::QUEUED;
+		else if (!stats.running && stats.completed && overMaxRatio())
+			stats.status = kt::SEEDING_COMPLETE;
 		else if (!stats.running && stats.completed)
-			stats.status = kt::COMPLETE;
+			stats.status = kt::DOWNLOAD_COMPLETE;
 		else if (!stats.running)
 			stats.status = kt::STOPPED;
 		else if (stats.running && stats.completed)
@@ -1131,8 +1133,10 @@
 		{
 			case kt::NOT_STARTED :
 				return i18n("Not started");
-			case kt::COMPLETE :
-				return i18n("Completed");
+			case kt::DOWNLOAD_COMPLETE :
+				return i18n("Download Completed");
+			case kt::SEEDING_COMPLETE :
+				return i18n("Seeding Completed");
 			case kt::SEEDING :
 				return i18n("Seeding");
 			case kt::DOWNLOADING: