Bug 133423

Summary:	transcoding files for transfer to media device triggers auto search option for the collection
Product:	[Applications] amarok	Reporter:	Gavin Hyde <gshyde>
Component:	Collections/Media Devices	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.4.2
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Gavin Hyde 2006-09-02 05:29:34 UTC

Version:           1.4.2 (using KDE KDE 3.5.4)
Installed from:    Ubuntu Packages
OS:                Linux

when I'm transfering to my ipod I have to turn off the autoscan for my collection because the transcoded file to transfer triggers an update to my collection and it locks my system up. I have to turn auto scan off to transfer. It would be nice if either the file was flagged not to be included in the collection or created in a location outside the collection to not need to turn this  option off when connecting to my ipod.

Comment 1 Seb Ruiz 2006-09-03 01:34:11 UTC

Yes, you are correct.

Comment 2 Gavin Hyde 2006-09-04 06:18:23 UTC

does this mean that I am correct and this is what I will always have to do to transfer songs or I'm right and this is going to be changed?

Comment 3 Martin Aumueller 2006-09-04 10:30:18 UTC

Why don't you just configure your transKode script to put the transcoded files somewhere outside your collection?

Comment 4 Gavin Hyde 2006-09-04 15:41:46 UTC

Because I do things like ripping songs into flac mode first and use amarok to transcode to ogg. (I put the flac files on an external harddrive for archival purposes. If I have to do something like this then I will, just making sure this is expected behavior first.

Comment 5 Martin Aumueller 2006-09-25 23:56:01 UTC

SVN commit 588414 by aumuell:

disable collection rescan while transcoding (as the transcoded file might be created in a collection directory)
BUG: 133423


 M  +1 -0      ChangeLog  
 M  +3 -2      src/collectiondb.cpp  
 M  +1 -0      src/mediabrowser.h  


--- trunk/extragear/multimedia/amarok/ChangeLog #588413:588414
@@ -29,6 +29,7 @@
     * Show a proper tag dialog when viewing information for DAAP music shares.
 
   BUGFIXES:
+    * Don't rescan collection while transcoding. (BR 133423)
     * Don't try to copy to collection from urls without kio slaves.
     * Don't quit immediately if amarokrc was removed. (BR 134439)
     * The DAAP client would crash Amarok under certain conditions when 
--- trunk/extragear/multimedia/amarok/src/collectiondb.cpp #588413:588414
@@ -4829,8 +4829,9 @@
 void
 CollectionDB::scanMonitor()  //SLOT
 {
-    if ( AmarokConfig::monitorChanges() &&
-         ( !CollectionView::instance() || !CollectionView::instance()->isOrganizingFiles() ) )
+    if ( AmarokConfig::monitorChanges()
+            && ( !CollectionView::instance() || !CollectionView::instance()->isOrganizingFiles() )
+            && ( !MediaBrowser::instance() || !MediaBrowser::instance()->isTranscoding() ) )
         scanModifiedDirs();
 }
 
--- trunk/extragear/multimedia/amarok/src/mediabrowser.h #588413:588414
@@ -186,6 +186,7 @@
         QString getDisplayPluginName ( const QString string ) { return m_pluginAmarokName[string]; }
         const KTrader::OfferList &getPlugins() { return m_plugins; }
         void transcodingFinished( const QString &src, const QString &dst );
+        bool isTranscoding() const { return m_waitForTranscode; }
         void updateStats();
         void updateButtons();
         void updateDevices();