Bug 133186

Summary: < and > in contact nicknames aren't well supported
Product: [Applications] kopete Reporter: Yann LE HIR <yann.lehir>
Component: generalAssignee: Kopete Developers <kopete-bugs-null>
Severity: normal    
Priority: NOR    
Version: SVN   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Screenshot of the balloon window

Description Yann LE HIR 2006-08-29 15:46:29 UTC
Version:           SVN (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages
Compiler:          gcc 3.4.6 (Gentoo 3.4.6-r1, ssp-3.4.5-1.0, pie-8.7.9) 
OS:                Linux

When someone with < and/or > in his nickname send me a message the balloon window doesn't correctly show the nickname

I have the same problem in the chat window whith kOne theme ( http://www.kde-look.org/content/show.php?content=36477 )

I'll post some screenshots
Comment 1 Yann LE HIR 2006-08-29 16:00:53 UTC
Created attachment 17552 [details]
Screenshot of the balloon window

The nickname should be © >†<ØñÐiñê>†<Mi§§ Chøµpïññette
Comment 2 Olivier Goffart 2006-08-29 16:32:43 UTC
What is your ckopete version ?
Can you try with Kopete 0.12.2 ?
I remember having fixed that issue already been fixed in the past.  But maybe it's a new one.
Comment 3 Yann LE HIR 2006-08-29 16:55:08 UTC
I have kopete SVN (the installation is 3 days old)

And it's with msn protocol, I did'nt try with other protocols.
Comment 4 Matt Rogers 2007-06-09 04:58:04 UTC
SVN commit 673127 by mattr:

fix bug 133186 by escaping the nickname text when passing it to the balloon.
For the kOne chat style, that would be a bug in the style since it works here
with the default Kopete style.

BUG: 133186

 M  +1 -1      systemtray.cpp  

--- branches/KDE/3.5/kdenetwork/kopete/kopete/systemtray.cpp #673126:673127
@@ -302,7 +302,7 @@
 			m_balloon = new KopeteBalloon(
 				i18n( "<qt><nobr><b>New Message from %1:</b></nobr><br><nobr>\"%2\"</nobr></qt>" )
-					.arg( msgFrom, msgText ), QString::null );
+					.arg( QStyleSheet::escape( msgFrom ), msgText ), QString::null );
 			connect(m_balloon, SIGNAL(signalBalloonClicked()), mBalloonEventList.first() , SLOT(apply()));
 			connect(m_balloon, SIGNAL(signalButtonClicked()), mBalloonEventList.first() , SLOT(apply()));
 			connect(m_balloon, SIGNAL(signalIgnoreButtonClicked()), mBalloonEventList.first() , SLOT(ignore()));