Bug 133169

Summary: "/ctcp $nick version" outputs a requesting ctcp version message wheras right-clicking on a nick and selecting version does not
Product: [Applications] konversation Reporter: Niek Beernink <n.beernink>
Component: generalAssignee: Konversation Developers <konversation-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Niek Beernink 2006-08-29 08:33:40 UTC 
Version:           1.0rc1 #3148 (using KDE 3.5.4, Kubuntu Package 4:3.5.4-0ubuntu6 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-25-k7

How to reproduce:

1. In a channel, /ctcp $nick version someone.
2. Notice how this outputs "[CTCP] Sending CTCP-version request to $nick" after which you may or may not get a reply from the other side.
3. Now right-click on this nickname in the nicklist and select version.
4. Notice how this doesn't show the requesting message first, but immediately shows the version message instead.

This behavior is inconsistent with how the ping command works. There, commandline and context manual induction of the command works consistently.
Comment 1 Eike Hein 2006-08-29 13:56:18 UTC 
SVN commit 578457 by hein:

Make CTCP input box command and context menu action behave consistently.
BUG:133169


 M  +2 -3      channel.cpp  
 M  +1 -1      commit.h  


--- trunk/extragear/network/konversation/src/channel.cpp #578456:578457
@@ -482,8 +482,7 @@
             raw=true;
             break;
         case Konversation::Version:
-            pattern="PRIVMSG %u :\x01VERSION\x01";
-            raw=true;
+            pattern=cc+"CTCP %u VERSION";
             break;
         case Konversation::Whois:
             pattern="WHOIS %u %u";
@@ -501,7 +500,7 @@
         case Konversation::Ping:
         {
             unsigned int time_t = QDateTime::currentDateTime().toTime_t();
-            pattern=QString(Preferences::commandChar()+"CTCP %u PING %1").arg(time_t);
+            pattern=QString(cc+"CTCP %u PING %1").arg(time_t);
         }
         break;
         case Konversation::Kick:
--- trunk/extragear/network/konversation/src/commit.h #578456:578457
@@ -1,4 +1,4 @@
 // This COMMIT number is added to version string to be used as "patch level"
 #ifndef COMMIT
-#define COMMIT 3148
+#define COMMIT 3149
 #endif