Bug 133078

Summary: an idea howto get rid of 'remove played tracks'
Product: [Applications] amarok Reporter: baum-im-wald
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: 1.4-SVN   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description baum-im-wald 2006-08-27 16:37:40 UTC 
Version:           1.4-SVN (using KDE 3.5.3, Kubuntu Package 4:3.5.3-0ubuntu0.2 dapper)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-23-386

the option to 'remove played tracks' in the dynamic mode settings is somehow conflicting with the spinbox that let's you choose how many played tracks to show. this is confusing.

if 'remove played tracks' is set to on, eveything is fine and you can set how many of them to keep in the list;

but if 'remove played tracks' is set to off, it's of no use to set a maxinum of tracks to keep, because all just stay there. (it would only affect the _initial_ number of tracks that are shown and this would be incremented every time a song is played.)

suggestion:
the spinbox does not yet allow the value 0. below the 1 there could be a setting called 'infinite' or 'all'. then the checkbox could be removed.
Comment 1 Seb Ruiz 2006-08-31 02:40:09 UTC 
SVN commit 579071 by seb:

* Remove the option to enable/disable history in dynamic mode. It is now on always.
* Disable "Played tracks to show" option if tracks are not removed from dynamic mode, when creating a new dynamic playlist
* Reduce the minimum available tracks to show to 0.
* The beginnings of restoring purged items for podcasts (got caught up in the commit).

BUG: 133078
BUG: 133076
BUG: 131223



 M  +2 -0      ChangeLog  
 M  +0 -3      src/dynamicmode.cpp  
 M  +0 -3      src/dynamicmode.h  
 M  +25 -35    src/newdynamic.ui  
 M  +24 -30    src/playlist.cpp  
 M  +1 -1      src/playlist.h  
 M  +0 -4      src/playlistbrowser.cpp  
 M  +50 -11    src/playlistbrowseritem.cpp  
 M  +1 -0      src/playlistbrowseritem.h  
 M  +0 -2      src/playlistselection.cpp
Comment 2 baum-im-wald 2006-08-31 21:36:53 UTC 
well, this is not quite what i requested but it's also a good way to make this thing easier to understand. just one thing: there still is a horizontal line between "remove played tracks" and "played tracks to show" which seems out of place as both items are belonging together.
Comment 3 richlv 2006-09-01 09:13:22 UTC 
if i understood you correctly, you suggested removing also the option "remove played tracks", right ?
instead, "played tracks to show" would have the ability to be set to 0 (as it is in the current svn), which would mean "do not remove".

that would allow cleaning up the dialog even further, but one problem arises - what if user does not want to have played tracks history - if "0" means "leave them", how could "show no played tracks" be achieved ?
Comment 4 baum-im-wald 2006-09-01 21:55:47 UTC 
> that would allow cleaning up the dialog even further, but one problem
> arises - what if user does not want to have played tracks history - if "0"
> means "leave them", how could "show no played tracks" be achieved ?


you're right. this is indeed a problem. and it's why i'm very content with the 
current solution. however, one way to remove the option now would be to have 
an "all" option coded into the spinbox instead of the value '-1' but this 
would be very difficult to find. another idea would be to have a slider with 
'0' as minimum and "all" as maximum with the disadvantage that this would not 
actually clean up the dialog.
so i think it's good how it is now.