Bug 133013

Summary:	Pause does still work when playing last.fm streams
Product:	[Applications] amarok	Reporter:	Elias Probst <mail>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	me
Priority:	NOR
Version:	2.0-SVN
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Elias Probst 2006-08-26 09:52:02 UTC

Version:           1.4.2 (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages

When playing a Last.fm stream, the pause button is greyed out. But "internal", pause still works (when using dcop, the Mediacontrol Kicker applet, the keyboard shortcut for "pause", ...).
Please fix this, as I often accidentally push "Meta+C" or the pause button at the Mediacontrol Kicker applet while playing a Last.fm stream.

Comment 1 Seb Ruiz 2006-11-15 02:20:21 UTC

SVN commit 605024 by seb:

Forbid pausing the engine when using lastfm. Now pause can't be issued from dcop or shortcuts.
BUG: 133013


 M  +1 -1      enginecontroller.cpp  


--- trunk/extragear/multimedia/amarok/src/enginecontroller.cpp #605023:605024
@@ -493,7 +493,7 @@
 
 void EngineController::pause() //SLOT
 {
-    if ( m_engine->loaded() )
+    if ( m_engine->loaded() && !LastFm::Controller::instance()->isPlaying() )
         m_engine->pause();
 }

Comment 2 Elias Probst 2008-06-17 21:29:59 UTC

Affects now Amarok 2.x.

Comment 3 Mark Kretschmann 2008-07-10 11:50:40 UTC

In Amarok 2 it is now actually possible to pause and resume Last.fm streams without problems :)