Bug 132987

Summary:	"Show quick buttons" and "Show channel nick list and quick buttons" are confusing
Product:	[Applications] konversation	Reporter:	Albert Astals Cid <aacid>
Component:	general	Assignee:	Konversation Bugs <konversation-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Albert Astals Cid 2006-08-25 20:09:02 UTC

Version:           0.19+ #3140 (using KDE 3.5.4, compiled sources)
Compiler:          Target: x86_64-linux-gnu
OS:                Linux (x86_64) release 2.6.15-26-amd64-k8

Well, that is all imho, feel free to ignore it.

I think the current way of showing those options is somewhat confusing because i may have "Show channel nick list and quick buttons" but quick buttons are not ensured to be shown.

Instead
* Show channel nick list and quick buttons
* some other options 
* Show quick buttons

i think it would be better to have

* Show channel nick list
|-> * Show quick buttons
* some other options 

Having "Show quick buttons" enabled/disabled when "Show channel nick list" is checked/unchecked.

The |-> means some indenting, not having a real arrow.

Comment 1 Eike Hein 2006-08-25 20:21:37 UTC

SVN commit 577154 by hein:

Indent the conditional nicklist options in Interface -> Chat Window.
BUG:132987


 M  +46 -12    chatwindowappearance_preferences.ui  


--- trunk/extragear/network/konversation/src/chatwindowappearance_preferences.ui #577153:577154
@@ -12,8 +12,8 @@
         <rect>
             <x>0</x>
             <y>0</y>
-            <width>525</width>
-            <height>526</height>
+            <width>399</width>
+            <height>476</height>
         </rect>
     </property>
     <vbox>
@@ -159,7 +159,7 @@
                 <property name="name">
                     <cstring>unnamed</cstring>
                 </property>
-                <widget class="QCheckBox" row="0" column="0">
+                <widget class="QCheckBox" row="0" column="0" rowspan="1" colspan="2">
                     <property name="name">
                         <cstring>kcfg_ShowTopic</cstring>
                     </property>
@@ -167,7 +167,7 @@
                         <string>&amp;Show channel topic</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="1" column="0">
+                <widget class="QCheckBox" row="1" column="0" rowspan="1" colspan="2">
                     <property name="name">
                         <cstring>kcfg_ShowModeButtons</cstring>
                     </property>
@@ -175,24 +175,58 @@
                         <string>Show channel &amp;mode buttons</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="5" column="0">
+                <widget class="QCheckBox" row="2" column="0" rowspan="1" colspan="2">
                     <property name="name">
-                        <cstring>kcfg_ShowNicknameBox</cstring>
+                        <cstring>kcfg_ShowNickList</cstring>
                     </property>
                     <property name="text">
-                        <string>Show bo&amp;x to change own nickname</string>
+                        <string>Show channel &amp;nick list and quick buttons</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="2" column="0">
+                <widget class="QCheckBox" row="5" column="0" rowspan="1" colspan="2">
                     <property name="name">
-                        <cstring>kcfg_ShowNickList</cstring>
+                        <cstring>kcfg_ShowNicknameBox</cstring>
                     </property>
                     <property name="text">
-                        <string>Show channel &amp;nick list and quick buttons</string>
+                        <string>Show bo&amp;x to change own nickname</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="3" column="0">
+                <spacer row="3" column="0">
                     <property name="name">
+                        <cstring>spacer9</cstring>
+                    </property>
+                    <property name="orientation">
+                        <enum>Horizontal</enum>
+                    </property>
+                    <property name="sizeType">
+                        <enum>Fixed</enum>
+                    </property>
+                    <property name="sizeHint">
+                        <size>
+                            <width>16</width>
+                            <height>20</height>
+                        </size>
+                    </property>
+                </spacer>
+                <spacer row="4" column="0">
+                    <property name="name">
+                        <cstring>spacer10</cstring>
+                    </property>
+                    <property name="orientation">
+                        <enum>Horizontal</enum>
+                    </property>
+                    <property name="sizeType">
+                        <enum>Fixed</enum>
+                    </property>
+                    <property name="sizeHint">
+                        <size>
+                            <width>16</width>
+                            <height>20</height>
+                        </size>
+                    </property>
+                </spacer>
+                <widget class="QCheckBox" row="3" column="1">
+                    <property name="name">
                         <cstring>kcfg_AutoUserhost</cstring>
                     </property>
                     <property name="enabled">
@@ -202,7 +236,7 @@
                         <string>Show hostmas&amp;ks in nickname list</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="4" column="0">
+                <widget class="QCheckBox" row="4" column="1">
                     <property name="name">
                         <cstring>kcfg_ShowQuickButtons</cstring>
                     </property>

Comment 2 Eike Hein 2010-07-01 16:19:55 UTC

commit 3c391708f1c5adaba877d67d79eeb14476b6691f
Author: Eike Hein <hein@kde.org>
Date:   Fri Aug 25 18:21:31 2006 +0000

    Indent the conditional nicklist options in Interface -> Chat Window.
    BUG:132987
    
    svn path=/trunk/extragear/network/konversation/; revision=577154

diff --git a/src/chatwindowappearance_preferences.ui b/src/chatwindowappearance_preferences.ui
index 5888261..551e1db 100644
--- a/src/chatwindowappearance_preferences.ui
+++ b/src/chatwindowappearance_preferences.ui
@@ -12,8 +12,8 @@ the Free Software Foundation; either version 2 of the License, or
         <rect>
             <x>0</x>
             <y>0</y>
-            <width>525</width>
-            <height>526</height>
+            <width>399</width>
+            <height>476</height>
         </rect>
     </property>
     <vbox>
@@ -159,7 +159,7 @@ the Free Software Foundation; either version 2 of the License, or
                 <property name="name">
                     <cstring>unnamed</cstring>
                 </property>
-                <widget class="QCheckBox" row="0" column="0">
+                <widget class="QCheckBox" row="0" column="0" rowspan="1" colspan="2">
                     <property name="name">
                         <cstring>kcfg_ShowTopic</cstring>
                     </property>
@@ -167,7 +167,7 @@ the Free Software Foundation; either version 2 of the License, or
                         <string>&amp;Show channel topic</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="1" column="0">
+                <widget class="QCheckBox" row="1" column="0" rowspan="1" colspan="2">
                     <property name="name">
                         <cstring>kcfg_ShowModeButtons</cstring>
                     </property>
@@ -175,23 +175,57 @@ the Free Software Foundation; either version 2 of the License, or
                         <string>Show channel &amp;mode buttons</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="5" column="0">
+                <widget class="QCheckBox" row="2" column="0" rowspan="1" colspan="2">
                     <property name="name">
-                        <cstring>kcfg_ShowNicknameBox</cstring>
+                        <cstring>kcfg_ShowNickList</cstring>
                     </property>
                     <property name="text">
-                        <string>Show bo&amp;x to change own nickname</string>
+                        <string>Show channel &amp;nick list and quick buttons</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="2" column="0">
+                <widget class="QCheckBox" row="5" column="0" rowspan="1" colspan="2">
                     <property name="name">
-                        <cstring>kcfg_ShowNickList</cstring>
+                        <cstring>kcfg_ShowNicknameBox</cstring>
                     </property>
                     <property name="text">
-                        <string>Show channel &amp;nick list and quick buttons</string>
+                        <string>Show bo&amp;x to change own nickname</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="3" column="0">
+                <spacer row="3" column="0">
+                    <property name="name">
+                        <cstring>spacer9</cstring>
+                    </property>
+                    <property name="orientation">
+                        <enum>Horizontal</enum>
+                    </property>
+                    <property name="sizeType">
+                        <enum>Fixed</enum>
+                    </property>
+                    <property name="sizeHint">
+                        <size>
+                            <width>16</width>
+                            <height>20</height>
+                        </size>
+                    </property>
+                </spacer>
+                <spacer row="4" column="0">
+                    <property name="name">
+                        <cstring>spacer10</cstring>
+                    </property>
+                    <property name="orientation">
+                        <enum>Horizontal</enum>
+                    </property>
+                    <property name="sizeType">
+                        <enum>Fixed</enum>
+                    </property>
+                    <property name="sizeHint">
+                        <size>
+                            <width>16</width>
+                            <height>20</height>
+                        </size>
+                    </property>
+                </spacer>
+                <widget class="QCheckBox" row="3" column="1">
                     <property name="name">
                         <cstring>kcfg_AutoUserhost</cstring>
                     </property>
@@ -202,7 +236,7 @@ the Free Software Foundation; either version 2 of the License, or
                         <string>Show hostmas&amp;ks in nickname list</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox" row="4" column="0">
+                <widget class="QCheckBox" row="4" column="1">
                     <property name="name">
                         <cstring>kcfg_ShowQuickButtons</cstring>
                     </property>