Bug 132576

Summary: Match adblock filters against link HREFs
Product: [Applications] konqueror Reporter: Carsten Lohrke <carstenlohrke>
Component: khtml adblockAssignee: Konqueror Bugs <konqueror-bugs-null>
Status: RESOLVED UNMAINTAINED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: adblock-rules

Description Carsten Lohrke 2006-08-18 00:25:39 UTC 
Version:            (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages

On this¹ site I stumbled about this advert², which doesn't get blocked by Konqueror, but does by Firefox, using the same rules (see attched rule set)


[1] http://www.rennrad-news.de/forum/
[2] http://www10.mtb-news.de/anz/adclick.php?bannerid=135&zoneid=15&source=&dest=http%3A%2F%2Fwww.canyon.com
Comment 1 Carsten Lohrke 2006-08-18 00:26:06 UTC 
Created attachment 17407 [details]
adblock-rules
Comment 2 Andreas Kling 2006-08-18 13:00:49 UTC 
Your regexp doesn't cover "adimage.php", which is the image filename.

Make it "/(\/|\.|-)(ad(|client|click|s|server|tech|v|vert|image)|banners|werbung)(\/|\.|\?)/" and it'll work fine.
Comment 3 Carsten Lohrke 2006-08-18 19:32:39 UTC 
Hu? Any part of the url should match, not just the filename - and "/adclick." does.
Comment 4 Andreas Kling 2006-08-19 20:42:44 UTC 
The KHTML ad blocker doesn't filter on link URL's, it only looks at the image address. If you want that, open a feature request, this isn't a bug.
Comment 5 Andreas Kling 2006-09-03 16:15:46 UTC 
Reopening as wishlist, as per Carsten's request.
Comment 6 Christoph Cullmann 2024-05-06 20:52:37 UTC 
Dear user,

KHTML (and KJS) was a long time more or less unmaintained and got removed in KF6.

Please migrate to use a QWebEngine based HTML component.

We will do no further fixes or improvements to the KF5 branches of these components beside important security fixes.

For security issues, please see:

https://kde.org/info/security/

Sorry that we did not fix this issue during the life-time of KHTML.

Greetings
Christoph Cullmann