Bug 131736

Summary:	Queue Track and Stop Playing After Track do not work with streams
Product:	[Applications] amarok	Reporter:	Arend van Beelen jr. <arendjr>
Component:	Playlist	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.4.2-beta1
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Arend van Beelen jr. 2006-08-02 18:45:18 UTC

Version:           1.4.2-beta1 (using KDE KDE 3.5.2)
Installed from:    SuSE RPMs

It would be nice and more consistent if functions like Queue Track and Stop Playing After Track worked sensibly in combination with streams.

For example, I'm playing a stream and want the stream to stop after it has finished its current song, so I select Stop Playing After Track. Currently this has no effect at all and is just simply useless. I think it would make sense to just stop playing after the stream has finished its current song in this case. You may even consider to rename the action to Stop Playing After Song to reflect this if you implement this. If you do not want to implement this, please at least remove the option from the context menu.

Something similar can be said for the action Queue Track. If you're currently playing a stream and then queue a track from your playlist, it would make sense if Amarok jumped to the queued track as soon as the stream finishes its current song.

Finally, does it really make sense to have Repeat Track in the context menu of streams? At least the last.fm streams do not allow to put a song on repeat, are there streams that do? Could it be detected whether a stream supports this and make the option available accordingly?

Cheers, and congrats on your upcoming 1.4.2 release, it already appears to gonna be your best release ever ;)
Arend jr.

Comment 1 Martin Aumueller 2006-08-02 19:25:57 UTC

I see a use for these options: many users are connected via dial-up or other unreliable means. For them
- repeat would reconect to the stream when the connection is established again
- stop after would stop playing when the connection is interupted, ...

Comment 2 Seb Ruiz 2006-08-03 01:30:46 UTC

haha, dial up... now that is an answer i would never have thought of :)

Comment 3 Alexandre Oliveira 2006-12-31 15:10:21 UTC

SVN commit 618183 by aoliveira:

If the user is listening to a stream a queue a track on playlist, go to the queued track when current song of stream finishes.
BUG: 131736


 M  +1 -1      playlist.cpp  


--- trunk/extragear/multimedia/amarok/src/playlist.cpp #618182:618183
@@ -2005,7 +2005,7 @@
     {
         if ( m_currentTrack && !trackChanged ) {
             //if the track hasn't changed then this is a meta-data update
-            if( stopAfterMode() == StopAfterCurrent )
+            if( stopAfterMode() == StopAfterCurrent || !m_nextTracks.isEmpty() )
                 Playlist::instance()->playNextTrack( true );
             //this is a hack, I repeat a hack! FIXME FIXME
             //we do it because often the stream title is from the pls file and is informative

Comment 4 Alexandre Oliveira 2006-12-31 15:10:55 UTC

Stop After track was already done.