Bug 131034

Created attachment 17029 [details]
mockup ( image taken from showcast of digikam 0.9 ) showing the preview of the currently imported image

mockup ( image taken from showcast of digikam 0.9 ) showing the preview of the
currently imported image.

I take a random image because the right image was not completly visible. The
purpose is to illustrate what I mean

Salut Fabrice,

I fact digiKam camera gui implementation provide already a solution show witch item have already downloaded or not. The code have been never finalized by Renchi Raju (the original author of digiKam).

I have complete this job and also improved this one :

- camera gui will show a little icon on the top/right of item :

==> a star when it a non-downloaded item.
==> a blue gear when it's currenlty under download.
==> a green sign when it's downloaded sucessfuly.
==> a red cross if it cannot be downloaded from camera.

- During download, the current item in the icon view is always visible (if you have a big list of picture).
- Bonus : camera gui now support digiKam theme !
- The cameragui C++ object implementation have been very polished again, especially for some object where i haven't already checked the code. All object use a d private class to speed compilation. I have found also some little indeep bugs.

There is a screenshot at this url :

http://digikam3rdparty.free.fr/Screenshots/camera_gui_with_theme_and_icon_download_status.png

Attached a patch to close this B.K.O file (:=)))... I haven't yet commited the code in svn because digiKam is under finalization for 0.9.0-beta1 release. I would waiting than Marcel (an another digiKam developer) complete this release.

Also, this patch have been only tested with an UMS camera, not yet with a gphoto2 camera. Normally this is not a problem, but i want delayed a little the svn intergartion to have a feedback from users.

Bon tests (:=)))

Gilles Caulier

Created attachment 17034 [details]
patch to improve camera gui

Created attachment 17035 [details]
second version of cameragui improvement patch !!!

In this version the theme support in camera gui is complete (missing camera
icon item theme colored)

Dnia 

Normaly, if i have understand correctly the code, Gphoto2 camera set a flag to the camera when a picture have downloaded. 

Marcus, can you give me some hints about this point ?

MD5 checksum is out of this B.K.O file. There is already a file about this subject in B.K.O (#107316). It's more complicated to do and is only require by UMS camera (witch don't use Gphoto2 drivers in fact).

Gilles

Well, it would be possible in generalal if the libgphoto instance is open,
but this is not a common use case ;)

There is camera driver support (info.file.status == GP_FILE_STATUS_DOWNLOADED)
when (info.file.fields & GP_FILE_INFO_STATUS) is set, but only the Canon
camera driver supports this.
Other camera classes do not store such information.

Suggestions:
- Check name, filesize and filetime ... those are querieable from the camera
  without retrieving the full image. 
- You could also retrieve EXIF information and compare this blob with the
  one on-disk already.

(to be really really sure you have to check md5sums though ;)

Thanks Marcus for these informations.

Well a common solution will be an MD5 checksum stored somewhere in database for example. If we will use the database to store an items download status for each camera, the database structure need to be changed. I would do it later 0.9.0

Marcel, what do you think to use database for that ? Do you know another solution ?

Gilles

Created attachment 17048 [details]
new version witch fix B.K.O #127614

SVN commit 564596 by cgilles:

digikam from trunk : camera gui improvement and fix :

- fix rename customizer rule about custom prefix widget focus (#127614)
- Add small icon on top/roght of camera ites to indicate download status (#131034)
- Fix some minor internal bugs.
- Polish implementation.
- using d private class to speed up compilation
- camera gui support digiKam theme now. A screenshot :

http://digikam3rdparty.free.fr/Screenshots/camera_gui_with_theme_and_icon_download_status.png

BUG: 127614, 131034

CCMAIL: digikam-devel@kde.org



 M  +3 -1      NEWS  
 M  +0 -2      TODO  
 M  +14 -14    digikam/albumiconitem.cpp  
 M  +5 -0      digikam/albumiconitem.h  
 M  +166 -52   libs/imageproperties/cameraitempropertiestab.cpp  
 M  +1 -0      libs/imageproperties/cameraitempropertiestab.h  
 M  +13 -0     libs/imageproperties/imagepropertiessidebarcamgui.cpp  
 M  +1 -0      libs/imageproperties/imagepropertiessidebarcamgui.h  
 M  +1 -0      utilities/cameragui/Makefile.am  
 M  +158 -143  utilities/cameragui/cameracontroller.cpp  
 M  +1 -1      utilities/cameragui/cameracontroller.h  
 M  +245 -103  utilities/cameragui/cameraiconitem.cpp  
 M  +12 -22    utilities/cameragui/cameraiconitem.h  
 M  +99 -40    utilities/cameragui/cameraiconview.cpp  
 M  +10 -6     utilities/cameragui/cameraiconview.h  
 M  +28 -19    utilities/cameragui/cameraui.cpp  
 M  +1 -1      utilities/cameragui/cameraui.h  
 M  +5 -5      utilities/cameragui/dkcamera.cpp  
 M  +3 -3      utilities/cameragui/gpcamera.cpp  
 M  +13 -1     utilities/cameragui/gpiteminfo.h  
 M  +8 -2      utilities/cameragui/renamecustomizer.cpp  
 M  +7 -2      utilities/cameragui/renamecustomizer.h  
 M  +3 -3      utilities/cameragui/umscamera.cpp  

great job, this is awesome. Much better than I thought initially.

Thanks for all.

Sorry to reopen the bug report, I was was thinking about the implementation under my shower ( yeah, good for inspiration ), and I noticed that marking the photos which are going to be download with a star is somewhat useless and have no real meaning for an user.

So I agree with the green check for downloaded photos ( evident meaning ) and the gear for currently downloaded photo ( the same ), but IMHO the stars are too much ( and doesn't means really something, mostf of the times use for bookmarked stuffs ). The user know which ones need to be downloaded ... the ones selected. A better feedback would be to use a checkbox to clearly show wich photos are selected and which may ease the selection. see http://bugs.kde.org/show_bug.cgi?id=131036

Just my 0.02€

Fabrice.

Let's me explain better what i want with icon annotations under camera item thumbs. Current implementation from svn give :

1/ A gray "?" if the download status is unknow.
2/ A blue gear during download.
3/ A green check when the download is complete.
4/ A red cross when download is broken.
5/ A yellow start when the item is new in camera.

2/, 3/, and 4/ are not a problem. 

1/ and 5/ will be drived by a future implementation to manage the "already downloaded" status of camera items :

- Provided by Gphoto2 cameras using libgphoto2.
- Provided by digiKam itself for UMS cameras (TODO).

In fact look into #107316 B.K.O file about download status, and post comments into this thread...

Gilles

OK, sorry. All of this sounds sensible.