| Summary: | Ambiguous meaning of 320 numerical causing erroneous WHOIS display | ||
|---|---|---|---|
| Product: | [Applications] konversation | Reporter: | Eike Hein <hein> |
| Component: | protocol | Assignee: | Konversation Developers <konversation-devel> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 1.5-rc1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Eike Hein
2006-07-11 02:06:49 UTC
Addendum: We presently implement (b) and display what holds true on Dancer/Freenode, i.e. "[WHOIS] <user> is an identified user.") SVN commit 690835 by psn:
Let's treat 307 and 320 equally until we decide what to do with 320
CCBUG:130588
M +1 -12 inputfilter.cpp
M +1 -1 ircview.h
--- branches/extragear/kde3/network/konversation/src/inputfilter.cpp #690834:690835
@@ -1210,6 +1210,7 @@
}
// From a WHOIS.
//[19:11] :zahn.freenode.net 320 PhantomsDad psn :is an identified user
+ case RPL_WHOISIDENTIFY:
case RPL_IDENTIFIED:
{
NickInfo* nickInfo = server->getNickInfo(parameterList[1]);
@@ -1423,18 +1424,6 @@
}
break;
}
- case RPL_WHOISIDENTIFY:
- {
- // Display message only if this was not an automatic request.
- if(getAutomaticRequest("WHOIS",parameterList[1])==0)
- {
- server->appendMessageToFrontmost(i18n("Whois"),
- i18n("%1 has identified for this nick.")
- .arg(parameterList[1])
- );
- }
- break;
- }
case RPL_WHOISHELPER:
{
// Display message only if this was not an automatic request.
--- branches/extragear/kde3/network/konversation/src/ircview.h #690834:690835
@@ -73,7 +73,7 @@
void setNickAndChannelContextMenusEnabled(bool enable);
- signals:
+ signals:
// Notify container of new text and highlight state
void updateTabNotification(Konversation::TabNotifyType type);
void gotFocus(); // So we can set focus to input line
commit 7725f9034b0d2f0276ceff8e4ceac24ccdcf66a0 Author: Eike Hein <hein@kde.org> Date: Sat Jul 10 13:02:28 2010 +0200 Add support for UnrealIRCd's 671 numeric. CCBUG:130588 diff --git a/ChangeLog b/ChangeLog index 78d6085..d0baf51 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Changes since 1.3.1: +* Added support for UnrealIRCd's 671 numeric. + + Changes from 1.3 to 1.3.1: Konversation 1.3.1 is a maintenance release that improves program behavior and fixes defects, the most serious of which is a regression that unfortu- diff --git a/src/irc/inputfilter.cpp b/src/irc/inputfilter.cpp index ec3ae8a..00e3261 100644 --- a/src/irc/inputfilter.cpp +++ b/src/irc/inputfilter.cpp @@ -1464,6 +1464,15 @@ void InputFilter::parseServerCommand(const QString &prefix, const QString &comma } break; } + case RPL_WHOISSECURE: + { + if (plHas(2)) + { + if (getAutomaticRequest("WHOIS", parameterList.value(1)) == 0) + server->appendMessageToFrontmost(i18n("Whois"), i18n("%1 is using a secure connection.", parameterList.value(1))); + } + break; + } // Sample WHO response //"/WHO #lounge" //[21:39] [352] #lounge jasmine bots.worldforge.org irc.worldforge.org jasmine H 0 jasmine diff --git a/src/irc/replycodes.h b/src/irc/replycodes.h index 9b8fd6c..bd4b63e 100644 --- a/src/irc/replycodes.h +++ b/src/irc/replycodes.h @@ -157,5 +157,7 @@ #define ERR_UMODEUNKNOWNFLAG 501 #define ERR_USERSDONTMATCH 502 +#define RPL_WHOISSECURE 671 // used by UnrealIRCd to denote SSL in WHOIS response + #endif // REPLYCODES_H See discussion in http://bugs.unrealircd.org/view.php?id=2006 and http://bugs.unrealircd.org/view.php?id=3401 Is this still valid for 1.4 or 1.5 RC1? Yes; Eli is working on solving this with his ipf2 work. |