Summary: | konqueror cannot find graphic tag | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | S. Umar <umar> |
Component: | khtml ecma | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
S. Umar
2006-07-06 21:18:46 UTC
Actually, we find it 2 times (but fail to find it 3rd way), while mozilla only finds it once :-) function swapImage(strOrigImage, objNewImage) { var objOrigImage; if (document.getElementById(strOrigImage) != null) objOrigImage = document.getElementById(strOrigImage); if (document.all != null) objOrigImage = document.all[strOrigImage]; if (document.layers != null) objOrigImage = document.layers[strOrigImage]; if (objOrigImage != null && objNewImage != null) objOrigImage.src = objNewImage.src; else { if(objOrigImage == null) alert("Error: original graphic tag not found."); if(objNewImage == null) alert("Error: new image object not found."); } } Carewolf: your document.layers toy breaks stuff, so it should either work better (whatever that means), or hide better.. Actually both all and layers should equal null.. We had a patch for this years ago, and the same is done in WebCore. I'll go look for it. The layers work as the should, the image is not a layer in this case, but might have been if you identified as NS4. Identification as NS4 did not do it! This bug is still present in 3.5.4. I would really appreciate a patch! Thanks SVN commit 784105 by orlovich: Use the new KJS hook to better hide hidden collections BUG: 130376 M +4 -0 kjs_html.cpp M +1 -0 kjs_html.h WebSVN link: http://websvn.kde.org/?view=rev&revision=784105 SVN commit 784110 by orlovich: Regression test for collection hiding/130376 CCBUG:130376 A baseline/dom/collection-hiding.html-dom AM baseline/dom/collection-hiding.html-dump.png A baseline/dom/collection-hiding.html-render A tests/dom/collection-hiding.html WebSVN link: http://websvn.kde.org/?view=rev&revision=784110 |