Summary: | automatic spell check setting lost when switching conversation tabs | ||
---|---|---|---|
Product: | [Unmaintained] kopete | Reporter: | Vladimir Kanazir <canny> |
Component: | Chat Window | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Fix spellchecking
Fix spellchecking, follow context menu changes |
Description
Vladimir Kanazir
2006-06-28 19:39:53 UTC
Can confirm for 0.12.0 on 3.5.3, using Slackware packages, and aspell selected in Control Centre. Auto Spell Check works fine once turned on (via chat window text entry context menu), but yes, switching to another conversation tab and flicking back (even if that is all you do) loses the setting. This is despite having it switched on in the preferences. This default is seemingly ignored. I'm having the same problem with .12 in kubuntu Dapper. Me too with kopete 0.12.3 in kubuntu edgy. (kde 3.5.5) This also happens to me under Kubuntu Edgy using Kopete version 0.12.4. I'm using KDE version 3.5.6 *** This bug has been confirmed by popular vote. *** can confirm for svn trunk r830858 (~4.1-beta2) Created attachment 26066 [details]
Fix spellchecking
Fixes bug when spellchecker is always disabled by remembering if it was enabled
or disabled. The patch also removes restriction that spellchecker can't be
enabled if richtext is enabled. This restriction isn't needed anymore because
KTextEdit uses Highlighter.
It would be great if somebody could also test it and/or review it as I want to
push it into KDE 4.1.
Created attachment 26070 [details]
Fix spellchecking, follow context menu changes
Update of the patch that doesn't return something in the void toggle...
function and introduces an additional slot for updating the spell check action:
It is needed to listen to changes of the auto spell setting made through the
context menu action of the KTextEdit. This way the auto spell check setting in
the menu is also updated when the setting is changed through the context menu.
Oh, and working fine btw, so +1 for commiting from me :-) Looks fine to me. Please commit SVN commit 831935 by rjarosz: Allow spell-checking on html/rtf text. Save spellchecker settings for every chat window. Use global spellchecker settings (enable/disable). Patch checked and updated by Dennis Nienhüser. BUG: 136193 BUG: 129983 BUG: 160909 M +0 -27 chattexteditpart.cpp M +0 -15 chattexteditpart.h M +2 -2 chatview.cpp M +12 -35 kopetechatwindow.cpp M +3 -2 kopetechatwindow.h M +10 -6 krichtexteditpart.cpp M +12 -0 krichtexteditpart.h WebSVN link: http://websvn.kde.org/?view=rev&revision=831935 SVN commit 831936 by rjarosz: Backport commit 831935. Allow spell-checking on html/rtf text. Save spellchecker settings for every chat window. Use global spellchecker settings (enable/disable). Patch checked and updated by Dennis Nienhüser. CCBUG: 136193 CCBUG: 129983 CCBUG: 160909 M +0 -27 chattexteditpart.cpp M +0 -15 chattexteditpart.h M +2 -2 chatview.cpp M +12 -35 kopetechatwindow.cpp M +3 -2 kopetechatwindow.h M +10 -6 krichtexteditpart.cpp M +12 -0 krichtexteditpart.h WebSVN link: http://websvn.kde.org/?view=rev&revision=831936 |