Bug 129567

Hmm...
Ctrl+Z and Ctrl+Shift+Z are the shortcuts for Undo/Redo. That
does not exactly match the actions "Take back my last move" and
"Play the move just taken back again" (Ok, the latter perhaps):
"Undo/Redo" is typically used when editing some document state,
but playing a board game against a computer player does not
fit here: "Take back" undoes 2 moves, your opponents one and yours.

Additionally, Kenolaba offers a "Edit Position" mode where you
really can edit the board. For this edit mode, "Undo"/"Redo" would
make sense.

Josef

It is called Undo/Redo in other kdegames.
The only difference here is, that the "Forward" does nothing in the game, but sets a the move counter +1. Here it is no "redo". I see the problem of this behaviour, not being exactly the same as in the other games, but would be nice to have at least the "undo" feature at the standard shortcut.
Or maybe add "redo" as a new feature, split it from "forward" and rearange the menu. That'd not be done in a few minutes, I guess. ;) But it would bring kenolaba nearer to the other kdegames.

SVN commit 692450 by roffet:

BUG:129567
Removed non-standard shortcuts for the actions "Undo" and "Redo" (Pg-Up and Pg-Down) so that these KStandardGameAction s now use the standard shortcuts defined in libkdegames (Ctrl+Z and Ctrl+Shift+Z).


 M  +0 -3      AbTop.cpp  


--- trunk/playground/games/kenolaba/AbTop.cpp #692449:692450
@@ -169,10 +169,7 @@
   stopAction->setShortcut(Qt::Key_S);
 
   backAction = KStandardGameAction::undo( this, SLOT(back()), actionCollection() );
-  backAction->setShortcuts(KStandardShortcut::shortcut(KStandardShortcut::Prior));
-
   forwardAction = KStandardGameAction::redo( this, SLOT(forward()), actionCollection() );
-  forwardAction->setShortcuts(KStandardShortcut::shortcut(KStandardShortcut::Next));
 
   hintAction = KStandardGameAction::hint(this, SLOT(suggestion()), this);