Bug 129470

Summary: KAddressbook has duplicate menu item "New Contact..." when embedded in Kontact
Product: [Applications] kontact Reporter: Stefan Borggraefe <Stefan.Borggraefe>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: minor CC: montel, sniffy
Priority: NOR    
Version: CVS   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: show new entry only when not loaded as a part

Description Stefan Borggraefe 2006-06-20 09:33:46 UTC
Version:           1.2 (using KDE KDE 3.5.3)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Steps to reproduce:
1. In Kontact switch to "Contacts".
2. Inspect the "File" menu.
3. Be shocked about the duplicate menu item. ;-)
Comment 1 Stefan Borggraefe 2006-06-20 09:37:29 UTC
Sorry for the bugspam. I forgot to activate the reassign button when moving this bug to component "contacts". :-(
Comment 2 Thorsten Roeder 2006-06-21 19:54:34 UTC
Created attachment 16743 [details]
show new entry only when not loaded as a part

added proposed patch.
Comment 3 Chris Gow 2006-10-28 23:25:19 UTC
Stefan,

Does this still happen to you?

Works for me. KDE 3.5.5/Kontact 1.2.3 Kubuntu 6.10 (edgy)
Comment 4 Will Stephenson 2006-10-30 10:27:53 UTC
Confirmed
Comment 5 Will Stephenson 2006-10-30 15:04:19 UTC
I've tested the patch, and the menu item that it suppresses is the first one, leaving the Kontact-merged one at the bottom of the menu, which is a bad place for it usability wise.  I agree that this is a problem but it's not unique to kaddressbook, kmail also has its own New menu item (As well as one in the Message menu).  

I don't think this patch goes far enough.

I think the right fix would be to 1) 
remove the apps' owne items consistently, and merge the kontact action at the beginning of the apps' File menu, 
2) remove all File->New actions and rely on Message/Event/Feed/... new actions elsewhere.
3) Add native New actions to each app's file menu and not merge the kontact action at all.

I prefer 2).
Comment 6 Tobias Koenig 2007-02-04 14:39:53 UTC
Kontact specific bug that happens for other components as well...
Comment 7 Laurent Montel 2013-06-18 07:18:50 UTC
can't reproduce now.
For me it's fixed.