Summary: | jabber sms transport/gateway and its contacts are always shown offline | ||
---|---|---|---|
Product: | [Unmaintained] kopete | Reporter: | Jakub Grandys <me> |
Component: | Jabber Plugin | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Stefan.Borggraefe |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Jakub Grandys
2006-06-12 19:48:38 UTC
Can you tell me the name of the sms gateway. Is there an open sms gateway so i could try ? Part 1 is probably a dupe of bug 127811. Yes it is open, I'm using gmail account to connect to it. It is only one sms transport on jabber.autocom.pl server (you can see it in Kopete's service browser but it isn't possible to register). You can register with psi. It has many sms gateways to use (because of various phone companies) but after registration to it you can see the transport contact, it should be online but you can send to it "help" message and it will response, it means it is online. I know that first part is a dupe of bug 127811 (I've also confirmed this bug), I wanted to tell about whole story. What is more now I realized that transport isn't shown as a account (there is similar bug to this but with icq-transport, I've commented it) * use "smsy.jabber.autocom.pl" in the server field, you'll get sub service. (Kopete doesn't support subservice dirrectly yet) * HEre is what i get when i do a disco#info on the sms gateway <iq from="smsy.jabber.autocom.pl/WwwPlusa" type="result" ...> <query xmlns="http://jabber.org/protocol/disco#info"> <identity category="service" type="sms" name="ApaSMSAgent - WwwPlusa" /> ... it report itself as a "service" and not as a gateway as it should. according to http://www.jabber.org/registrar/disco-categories.html I think that you should report the bug to the gateway itself. * I'll hardcode that, you will tell me if it works. SVN commit 551297 by ogoffart: Hardcode broken identity for the sms gateway CCBUG: 129059 M +10 -0 jabbercontact.cpp --- branches/kopete/0.12/kopete/protocols/jabber/jabbercontact.cpp #551296:551297 @@ -1548,6 +1548,16 @@ break; //(we currently only support gateway) } + else if (ident.category == "service") + { + //The ApaSMSAgent is reporting itself as service (instead of gateway) which is broken. + //we anyway support it. See bug 127811 + if(ident.type == "sms") + { + is_transport=true; + tr_type=ident.type; + } + } } } SVN commit 551299 by ogoffart: consider a the 'online' status as online, even if it's noit in the XMPP RFC BUG: 129059 M +10 -1 jabberprotocol.cpp [UTF-8 ENCODING PROBLEMS] --- branches/kopete/0.12/kopete/protocols/jabber/jabberprotocol.cpp #551298:551299 @@ -247,10 +247,19 @@ { status = JabberKOSDND; } + else if (resource.status ().show () == "online") + { // the ApaSMSAgent sms gateway report status as "online" even if it's not in the RFC 3921 I found also the reason why contact are offline <presence from="smsy.jabber.autocom.pl/OrangeMbox" ... > <show>online</show> <priority>3</priority> </presence> the 'online' status in the <show/> tag is not valid according RFC3921 http://www.xmpp.org/specs/rfc3921.html#stanzas-presence there should not be a show element for online. Please report the bug to the gateway. (i'll workaround it in kopete anyway) Bug reported. Your fixes work. Thanks a lot! |