Bug 128921

Summary: User-assigned toolbar icons remain after resetting toolbar to Defaults
Product: [Unmaintained] kdelibs Reporter: techno_plume-coding
Component: kedittoolbarAssignee: David Faure <faure>
Status: RESOLVED DUPLICATE    
Severity: normal CC: andresbajotierra
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description techno_plume-coding 2006-06-10 00:37:56 UTC 
Version:            (using KDE KDE 3.5.3)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Resetting an application toolbar to the default configuration does not reset the icons on restored/original toolbar buttons set. Toolbar buttons themselves added by the user are removed, however. This happens in any application - KDE native apps, those users build from source etc.

The (reset to-)Defaults confirmation dialog indicates ALL of the toolbar will be restored to its original, default state. It doesn't make sense for the Reset option to remove all user-added toolbar buttons - which may or may not have custom icons applied to them - yet _not_ remove the user-changed icons on the Default buttons set. All properties should reset.

Steps to Reproduce:

i) Enter the 'Configure Toolbars' dialog box in an app e.g. Sys-V-init Editor/Kedit/Konqueror.
ii) The dialog box has a 'Change Icon' button. Select it to spawn kdialog box. Change the icon assigned to a toolbar button; any of the default toolbar buttons can be used. Any random icon from the selection can be used.
iii) For purpose of clearly illustrating this bug add a new toolbar button from the list - e.g. 'About KDE', to the application's toolbar.
iii) 'Apply' and confirm changes at the 'Configure Toolbars' dialog, so the toolbar button icon updates.
iv) Re-enter the 'Configure Toolbars' dialog and select 'Defaults'. 
v) At confirmation dialog "Do you really want to reset all toolbars of this application to their default? The changes will be applied immediately." choose 'Reset' option.
v) All buttons added by the user are, correctly, removed - irrespective of whether the user also assigned new icons to the extra buttons while adding them. kedittoolbar resets toolbar so only the default buttons are displayed. But 'custom icons' applied at (ii) remain assigned to the default toolbar buttons.
Comment 1 Dario Andres 2009-05-01 20:45:35 UTC 
Here using:

Qt: 4.5.1 (qt-copy  958974)
KDE: 4.2.71 (KDE 4.2.71 (KDE 4.3 >= 20090428))
kdelibs svn rev. 960693 / kdebase svn rev. 960693
on ArchLinux i686 - Kernel 2.6.29.1

I can partially reproduce the bug.
Steps:
- Open KWrite
- Go to Settings/Configure Toolbars
- Double click "About KDE" to add it to the default toolbar
The "About KDE" action appears in the right side, with the default K icon
- Click on the "About KDE" action in the right side and then click the "Change Icon" button
The change icon dialog appears
- Select a new icon for the action
The "About KDE" action in the right side has now the new icon.
- Clicking "OK" will add the "About KDE" action with the custom icon to the toolbar and close the "Configure Toolbars" dialog
- Go to Settings/Configure Toolbars

- Click the "Defaults" icon
- Click the "Reset" button

The "About KDE" action will be removed from the current actions (at right) and came back to the left side. However it still keeps the custom icon

HOWEVER

If you close KWrite and you reopen it again, the "About KDE" action now has its default icon again.

My thoughts:
This is not a major issue as the default icon will be back on restart (the custom icon is not saved if the action is not currently added). However this may confuse the users that expect a full "reset". (However if you want to change the custom icon, you may want to keep it if you change your mind and re-add the action)
Comment 2 Christoph Feck 2010-11-29 06:19:08 UTC 

*** This bug has been marked as a duplicate of bug 234581 ***