Bug 128796

Summary:	Creating Folders in 'Message Filters" not possible under "Local Folders"
Product:	[Unmaintained] kmail	Reporter:	Gerard Seibert <gerard.seibert>
Component:	filtering	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jjm, mstu, nebzero, nicolas.ternisien, seajey.serg
Priority:	NOR
Version:	1.9.1
Target Milestone:	---
Platform:	unspecified
OS:	FreeBSD
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Gerard Seibert 2006-06-07 23:03:35 UTC

Version:           1.9.1 (using KDE 3.5.2, compiled sources)
Compiler:          gcc version 3.4.4 [FreeBSD] 20050518
OS:                FreeBSD (i386) release 6.1-STABLE

I have discovered what I believe is a bug, or at the very least, a problem in KMail. When trying to create a new message filter, it is not possible to create a new folder under the "Local Folders" heading. Navigate to:

<Filter Rules>
<Filter Action>

Select: Move to Folder and then click the icon to browse for a folder to use. It is possible to create a new folder under any of the existing folders, but not a new folder under 'Local Folders".

Comment 1 Thiago Macieira 2006-06-11 23:52:11 UTC

Confirmed (r548000). Probably the result of not being allowed to select Local Folders at all.

Comment 2 Bram Schoenmakers 2007-03-08 19:54:09 UTC

*** Bug 141391 has been marked as a duplicate of this bug. ***

Comment 3 Thomas McGuire 2007-12-09 14:41:10 UTC

*** Bug 153696 has been marked as a duplicate of this bug. ***

Comment 4 Jonathan Marten 2008-02-27 11:37:08 UTC

Copied from 158482:

Confirmed in KMail 1.9.9 (KDE 3.5.9) and trunk. 
 
The problem is that the "New Subfolder" button is disabled in KMFolderSelDlg::slotUpdateBtnStatus() by: 
 
   enableButton( User1, folder() && 
                 ( !folder()->noContent() && !folder()->noChildren() ) ); 
 
For the root of the folder tree, folder() is NULL and so the button is disabled. 
 
There isn't a simple fix of just enabling the button and accepting NULL as meaning "root", because the required parent folder is passed down to KMFolderTree::addChildFolder().  There, a folder of NULL means "current selected item", which would create the new folder under the selected folder in the *main folder tree* (not the tree displayed in the dialogue). 
 
May need to add an additional parameter to addChildFolder() to specify "ignore what is selected in the GUI".

Comment 5 Jonathan Marten 2008-02-27 11:37:32 UTC

*** Bug 158482 has been marked as a duplicate of this bug. ***

Comment 6 Vsevolod Krishchenko 2009-02-14 01:00:48 UTC

The same problem found in KDE 4.2, KMail version 1.11.0.
It's quite annoying. Bug is 2.5 years old already.

Comment 7 Jonathan Marten 2009-02-16 19:38:12 UTC

Patch to fix submitted for review.  See http://reviewboard.kde.org/r/105

Comment 8 Jonathan Marten 2009-02-18 16:54:06 UTC

SVN commit 927934 by marten:

Allow a new top-level local folder to be created in the folder selection
dialogue (used, e.g, when configuring a filter rule with the "Move into Folder"
action).

Also make it obvious where the selected folder is not valid, by disabling
the "OK" button.

BUG:128796


 M  +5 -5      folderselectiondialog.cpp  
 M  +1 -1      folderselectiondialog.h  
 M  +45 -22    folderselectiontreewidget.cpp  
 M  +27 -8     folderselectiontreewidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=927934

Comment 9 Thomas McGuire 2009-02-19 08:58:56 UTC

SVN commit 928215 by tmcguire:

Backport r927934 by marten from trunk to the 4.2 branch:

Allow a new top-level local folder to be created in the folder selection
dialogue (used, e.g, when configuring a filter rule with the "Move into Folder"
action).

Also make it obvious where the selected folder is not valid, by disabling
the "OK" button.

CCBUG:128796



 M  +5 -5      folderselectiondialog.cpp  
 M  +1 -1      folderselectiondialog.h  
 M  +45 -22    folderselectiontreewidget.cpp  
 M  +27 -8     folderselectiontreewidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=928215