Bug 128576

Summary:	Replace entry in From: field with full name and address on replying if it exists in addressbook
Product:	[Unmaintained] kmail	Reporter:	Christopher Dietz <christopher.dietz>
Component:	addressbook	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED WAITINGFORINFO
Severity:	wishlist	CC:	luigi.toscano, mail, takuro
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch for recipientseditor.cpp updated patch for recipientseditor.cpp

Description Christopher Dietz 2006-06-03 17:30:02 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources

If I reply to a message that only contains an email address in the From: field I would like kmail to search for addressbook items matching the address and add the full name to the address.

Comment 1 Christopher Dietz 2006-06-03 17:35:46 UTC

Created attachment 16449 [details]
patch for recipientseditor.cpp

With this patch (against version 1.9.3 in kde 3.5.3) kmail tries to replace
every email address in a reply/forward with its correspondent addressbook
entry.

If someone could comment on the approach itself, coding style, ... I'd be more
than happy :-)

Comment 2 Ingo Klöcker 2006-06-03 23:43:38 UTC

Good idea.

Comments about the patch:
- Don't try to parse the message yourself. It will fail for the correct email address
    "I>K" <ik@whatever>
  and for Outlook-style email addresses like
    ik@whatever (bla)
  Use KPIM::splitAddress(...) instead.
- Put the '{' after the "else"
- Use // for comments in code.
- IMO you should only add the full name if the From: field contained only the raw email address. Otherwise, you should use the full email address as it was received.

Comment 3 Christopher Dietz 2006-06-04 13:04:29 UTC

Created attachment 16467 [details]
updated patch for recipientseditor.cpp

Thanks for your comments on the code! I tried to take care of the issues. 

I didn't know about the functions for email handling, but they surely make life
easier. I now use 'getEmailAddress' to extract the address.

The patch still tries to replace addresses including the full name because of
two reasons: First, I wanted to get rid of unnecessary "s. Next, some companies
include information for example about the department, which I also do not like
to include in the reply address. IMO the addressbook entry (if it exists) is
the best choice in most situations. But of course the patch in this form may
only suit my personal needs so I can change this.

Comment 4 Bram Schoenmakers 2007-03-09 18:47:03 UTC

*** Bug 127072 has been marked as a duplicate of this bug. ***

Comment 5 Christophe Marin 2009-06-14 23:19:43 UTC

*** Bug 186529 has been marked as a duplicate of this bug. ***

Comment 6 Myriam Schweingruber 2012-08-18 07:55:56 UTC

Thank you for your feature request. Kmail1 is currently unmaintained so we are closing all wishes. Please feel free to reopen a feature request for Kmail2 if it has not already been implemented.
Thank you for your understanding.

Comment 7 Luigi Toscano 2012-08-19 00:33:51 UTC

Instead of creating a new feature request, please confirm here if the wishlist is still valid for kmail2.