Bug 128528

Summary:	"Clean spaces" in Kmail composer removes all commas in the mail
Product:	[Unmaintained] kmail	Reporter:	Claudius Wettstein <claudius.wettstein>
Component:	general	Assignee:	Allen Winter <winter>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Claudius Wettstein 2006-06-02 23:30:55 UTC

Version:           1.9.3 (using KDE 3.5.3 Level "a" , unofficial build of SUSE )
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.13-15-debug

The command "Clean spaces" in the "Edit"-Menu of Kmail composer removes not only the spaces but also every comma in the text. Occurs on two different machines every time the command is executed. (Highly reproduceable..)

Comment 1 Magnus Holmgren 2006-06-03 00:09:15 UTC

Must be a typo, right?

--- kmcomposewin.cpp.orig       2006-06-03 00:08:14.070995984 +0200
+++ kmcomposewin.cpp    2006-06-03 00:08:17.279373851 +0200
@@ -4016,7 +4016,7 @@
   }

   // Squeeze tabs and spaces
-  QRegExp squeeze( "[\t, ]+" );
+  QRegExp squeeze( "[\t ]+" );
   s.replace( squeeze, QChar( ' ' ) );

   // Remove trailing whitespace

Comment 2 Allen Winter 2006-06-03 00:11:58 UTC

yep. my fault.
I'll fix.

Comment 3 Allen Winter 2006-06-03 18:17:39 UTC

SVN commit 547861 by winterz:

Don't remove commas when cleaning whitespace.
BUGS: 128528


 M  +1 -1      kmcomposewin.cpp  


--- branches/KDE/3.5/kdepim/kmail/kmcomposewin.cpp #547860:547861
@@ -4023,7 +4023,7 @@
   }
 
   // Squeeze tabs and spaces
-  QRegExp squeeze( "[\t, ]+" );
+  QRegExp squeeze( "[\t ]+" );
   s.replace( squeeze, QChar( ' ' ) );
 
   // Remove trailing whitespace