Bug 128507

Summary: [PATCH] kdm ignores pam_open_session failure
Product: [Unmaintained] kdm Reporter: Dirk Mueller <mueller>
Component: generalAssignee: kdm bugs tracker <kdm-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: devriese
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: (untested) patch

Description Dirk Mueller 2006-06-02 17:41:21 UTC
Version:            (using KDE KDE 3.5.3)
Installed from:    Compiled From Sources

this pam config: 

=== Cut ===
#%PAM-1.0
auth     sufficient     pam_ssh.so
auth     include        common-auth
account  include        common-account
password include        common-password
session  required       pam_ssh.so
session  include        common-session
session  required       pam_devperm.so
session  required       pam_resmgr.so
=== Cut ===

and logging in without correct ssh passphrase, it continues to log in. this is due to kdm ignoring error exit code of pam_open_session. though I can't come up with a concrete case, this could become a security issue.
Comment 1 Dirk Mueller 2006-06-02 17:43:30 UTC
Created attachment 16433 [details]
(untested) patch
Comment 2 Oswald Buddenhagen 2006-10-13 19:14:30 UTC
fixed for kde 3.5.6 and 4.0
Comment 3 Oswald Buddenhagen 2006-10-13 20:26:15 UTC
*** Bug 80032 has been marked as a duplicate of this bug. ***