Bug 128086

Summary:	For some view objects, maintain aspect can be lost when resized or newly created objects encounter bounds.
Product:	[Applications] kst	Reporter:	Duncan Hanson <duncan.hanson>
Component:	general	Assignee:	Duncan Hanson <duncan.hanson>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Duncan Hanson 2006-05-26 18:02:44 UTC

Version:            (using KDE KDE 3.5.0)
Installed from:    Compiled From Sources

Maintain aspect on resize/create new is slightly borked.

STEPS TO REPRODUCE:
1. Create a rectangle.
2. Resize it with the shift key pressed down to maintain aspect, until one edge of the rectangle encounters its parents' bounds. 

RESULT: 
The rectangle will start to lose its aspect.

EXPECTED BEHAVIOUR:
The rectangle maintains its aspect?

This behaviour is common to all of the other view objects, except lines (which were fixed in a recent bug). It's not a huge problem, but could be annoying for picture objects.

It also occurs for all view objects when creating new. Right now, creating new objects and resizing them use completely different code. I'll try to bring them together.

I think that fixing this bug may require removing the current snap on resize behaviour, at least when objects are resized with maintain aspect. Are there any objections to this?

Comment 1 George Staikos 2006-05-26 18:35:58 UTC

 Please slow down with this.  I need to stabilize trunk and there's too much 
code being touched and too many changes happening in areas that should be 
changed very carefully and with review.  In fact, as I mentioned before, 
changes like this need to be done in a branch.  I'm going to be doing some 
work on trunk over the next 24 hours which will quite possibly involve 
backing out all the recent view object changes and moving them into a branch.  
Preserving aspect ratio is not worth the risk of introducing new bugs in 
areas that worked or possibly making inappropriate design changes in the view 
object code.  We need to have a stable build of Kst trunk for the HFI branch 
as of this weekend, and we need to have a Kst ready for a release sometime 
soon.

Thanks

Comment 2 Duncan Hanson 2007-02-07 00:08:23 UTC

View aspect branch has been merged.