Bug 128041

Summary:	Compilation fails for cdf datasource when library is present but not header
Product:	[Applications] kst	Reporter:	Andrew Walker <arwalker>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Andrew Walker 2006-05-25 22:07:00 UTC

Version:           HEAD (using KDE KDE 3.5.0)
Installed from:    Compiled From Sources
OS:                Linux

STEPS TO REPRODUCE:
Ensure you have a valid copy of libcdf.a on the LIB path
Ensure you have no copy of cdf.h on the INCLUDE path
Run configure
Make Kst

RESULTS:
Building the cdf datasource fails

EXPECTED RESULTS:
The cdf datasource should not attempt to build

Comment 1 George Staikos 2006-05-27 11:39:44 UTC

SVN commit 545285 by staikos:

quote arguments to avoid shell script errors when the variables are empty
BUG: 128041


 M  +6 -6      configure.in.in  


--- trunk/extragear/graphics/kst/configure.in.in #545284:545285
@@ -97,8 +97,8 @@
 KDE_CHECK_LIB(cdf, CDFlib, CDFLIBS="$ac_cdf_libraries -lcdf $CDFLIBS", , )
 LDFLAGS="$ldflags_save"
 
-if test $ac_cv_lib_cdf_CDFlib = yes; then
-  if test $have_cdf_h = yes; then
+if test "x$ac_cv_lib_cdf_CDFlib" = "xyes"; then
+  if test "x$have_cdf_h" = "xyes"; then
     AC_SUBST(CDFLIBS)
     AC_SUBST(CDFINCLUDES)
     AC_DEFINE(KST_HAVE_CDF, 1, [If we have the CDF libraries.])
@@ -130,8 +130,8 @@
   KDE_CHECK_LIB(netcdf, nc_open, NETCDFLIBS="$ac_netcdf_libraries -lnetcdf_c++ -lnetcdf $NETCDFLIBS", , )
   LDFLAGS="$ldflags_save"
 
-  if test $ac_cv_lib_netcdf_nc_open = yes; then
-    if test $have_netcdfcpp_h = yes; then
+  if test "x$ac_cv_lib_netcdf_nc_open" = "xyes"; then
+    if test "x$have_netcdfcpp_h" = "xyes"; then
       AC_SUBST(NETCDFLIBS)
       AC_SUBST(NETCDFINCLUDES)
       AC_DEFINE(KST_HAVE_NETCDF, 1, [If we have the NetCDF libraries.])
@@ -144,8 +144,8 @@
 # Readline and ncurses check
 KDE_CHECK_HEADER(readline/readline.h, AC_DEFINE(HAVE_READLINE_H, 1, [If we have libreadline headers]) have_readline_h=yes, , )
 KDE_CHECK_LIB(readline, rl_cleanup_after_signal, LIBREADLINE="-lreadline -lncurses", , -lncurses)
-if test $ac_cv_lib_readline_rl_cleanup_after_signal = yes; then
-  if test $have_readline_h = yes; then
+if test "x$ac_cv_lib_readline_rl_cleanup_after_signal" = "xyes"; then
+  if test "x$have_readline_h" = "xyes"; then
     AC_SUBST(LIBREADLINE)
     AC_DEFINE(KST_HAVE_READLINE, 1, [If we have libreadline.])
   else