| Summary: | click on parent folder in tree should generate a reaction | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Thorsten Schnebeck <thorsten.schnebeck> |
| Component: | Albums-TreeView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 0.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.9.4 | |
| Sentry Crash Report: | |||
| Attachments: | View all albums which are in the specific month | ||
|
Description
Thorsten Schnebeck
2006-05-07 00:49:03 UTC
Created attachment 18315 [details]
View all albums which are in the specific month
I thought the same thing, either the tree should expand bei clicking on an album with only sub-albums but also when clicking on the month. The attachment with a preview is in the Comment above this one. This is related to bug #128231. Can you comment, whether the display of images in subfolders could be a reaction you ask for? Showing images of subfolders then does not really reflect the aim of creating and using a hierarchical treeview. If you have a deep nested album stucture such a recursive album view whould also looks very "flickering" when navigating in the tree. I think the mockup in the attachmend made by Chris (#1) is the way to go :-) Bye Thorsten > Showing images of subfolders then does not really reflect > the aim of creating and using a hierarchical treeview. If you have a deep > nested album stucture such a recursive album view whould also looks very > "flickering" when navigating in the tree. I think the mockup in the > attachmend made by Chris (#1) is the way to go :-) Well, I am asking, because that's exactly the way it works in the tag tree, which is also recursive. And I think, that it makes a lot of sense there, so why not also in the album tree? I am fond of unifying the behaviour of the album/dates/tags trees, as described in bug #140743. As far as I see, you cannot keyboard-navigate in the album tree, so flickering shouldn't be a problem. With new patch from Arnd for Bug 128231 should unify behavior for tags and albums and fix that bug (although not in exactly way you wish - but IMO better :) SVN commit 768470 by cgilles: digiKam from KDE3 branch : Calendar View : When selecting Year album now show all pictures taken during this year. BUG: 144337 CCBUGS: 140743 CCBUGS: 126871 M +28 -6 digikam/album.cpp M +13 -2 digikam/album.h M +59 -16 digikam/albummanager.cpp M +44 -52 digikam/datefolderview.cpp M +3 -3 digikam/datefolderview.h M +13 -11 kioslave/digikamdates.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=768470 SVN commit 768997 by cgilles: digiKam from trunk : backport commit #768470 from KDE3 branch. CCBUGS: 144337 CCBUGS: 140743 CCBUGS: 126871 M +41 -47 datefolderview.cpp M +3 -3 datefolderview.h WebSVN link: http://websvn.kde.org/?view=rev&revision=768997 SVN commit 829440 by aclemens: Single click action on the folder icon or name will expand / collapse the underlying tree. BUGS:126871 M +2 -1 NEWS M +11 -0 digikam/folderview.cpp M +3 -3 digikam/folderview.h WebSVN link: http://websvn.kde.org/?view=rev&revision=829440 SVN commit 829445 by aclemens: backport commit #829440from KDE3 branch CCBUGS: 126871 M +11 -0 folderview.cpp M +4 -4 folderview.h WebSVN link: http://websvn.kde.org/?view=rev&revision=829445 Hi, I find this new behavior in albums view really annoying. Usually, I have an album (eg 2008-07-xx_Annecy) and inside, I have the best pictures + several sub-albums (videos, misc, ...). Each time I click on the main album, it collapses (if already opened), and I have to click it a second time to see sub-albums. I think it should at least respect standard KDE behavior, depending on configuration (single-click or double-click to open folders)... If you don't click the name it will not collapse... I remember that we tried to do it with double-click but it didn't work... or maybe this was the selecting of tags? Gilles, when was double-click not usable? Selecting tags? Now we have middle mouse button to select tags... Andi, yes, double-click is not usable? Gilles Usable was the wrong word, we couldn't filter it the right way... but I guess this was because of assigning tags. So what to do here? I can't remember now but I guess we had discussed double-click vs. single-click in the past. Maybe this could be configured in main settings dialog? I like it the way it is, if you click not the name or icon you can select the folder, otherwise it will expand/collapse. But sure some users might find it annoying. Personally, the new behaviour is better than old one. just clicking on text tag to open it is fine. A settings in Album config panel can be fine too to customize this behaviour. It's simple to implement. I would to hear other viewpoints here... Gilles I think Fabien is not complaining about the collapse/expand on single click in general, but about a special situation. Imagine the tags - Paris |- Notre Dame |- Arc de Triomphe You have selected "Notre Dame", then go back to "Paris", the album "Paris" is selected, but "Notre Dame" and "Arc de Triomphe" are collapsed. To go to "Arc de Triomphe" next, you have to re-expand by clicking on Paris a second time. Possible solutions: 1) Do not collapse on single click if the item was not previously selected (my vote for this) 2) Do not collapse on single click if a child item was previously selected People wont usually get the fact that you can click on the far right to "only" select without expanding. Auto-expanding on click can be a good idea. Ah, now i understand better. Thanks Marcel.
>1)Do not collapse on single click if the item was not previously selected (my >vote for this)
Fine for me too. Can you find you a way to do it in code ?
Gilles
SVN commit 840766 by aclemens: When using shortcuts to assign ratings in image editor, apply them immediately. CCBUGS:126871 M +36 -6 imagewindow.cpp M +7 -0 imagewindow.h WebSVN link: http://websvn.kde.org/?view=rev&revision=840766 Oops, this was the wrong bugreport... sorry :-) Hi, Sorry, I wasn't very precise. I was talking about Album view. I post my comment in this bug entry because I saw the commit in folderview.cpp (2008-07-08 16:10). Anyway, your comments also apply to the folder view :) I'm also for "Do not collapse on single click if the item was not previously selected". Thanks. SVN commit 902912 by mwiesweg: Following the discussion of bug 126871: Do not collapse on single click if the item was not previously selected (This already includes "Do not collapse on single click if a child item was previously selected") This is for now not done for check list items, as there selection has no special purpose. CCBUG: 126871 M +14 -1 folderview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=902912 |