Bug 126016

Summary:	message notification in contactlist
Product:	[Unmaintained] kopete	Reporter:	bauerfichtner
Component:	general	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description bauerfichtner 2006-04-21 12:50:26 UTC

Version:           svn (532114) (using KDE KDE 3.5.2)
Installed from:    SuSE RPMs
Compiler:          gcc 4.0.2 
OS:                Linux

The message notification in the contaclist (the blinking envelope) and in the system tray (the rotating Kopete icon) also appear when you are already chatting with the contact, the message comes from. 

So, I am chatting with contact A; contact A sends a message (which appears in the chatwindow immediately) and I get the notifications in the contact list and the system tray. Before installing revision 532114, the behaviour was different (these notifications only appeared, if no chatwindow with that contact was open).

Comment 1 Jan Ritzerfeld 2006-04-21 16:56:17 UTC

SVN commit 532282 by jritzerfeld:

Fixed missing parentheses introduced in revision 532112.

CCBUG: 126016

 M  +2 -2      kopeteviewmanager.cpp  


--- branches/kopete/0.12/kopete/libkopete/private/kopeteviewmanager.cpp #532281:532282
@@ -175,7 +175,7 @@
 			// append msg event to queue if chat window is active but not the chat view in it...
 			appendMessageEvent = appendMessageEvent && !(w->isActiveWindow() && manager->view() == d->activeView);
 			// ...and chat window is on another desktop
-			appendMessageEvent = appendMessageEvent && !d->queueOnlyMessagesOnAnotherDesktop || !KWin::windowInfo( w->topLevelWidget()->winId(), NET::WMDesktop ).isOnCurrentDesktop();
+			appendMessageEvent = appendMessageEvent && (!d->queueOnlyMessagesOnAnotherDesktop || !KWin::windowInfo( w->topLevelWidget()->winId(), NET::WMDesktop ).isOnCurrentDesktop());
 		}
 		else
 		{
@@ -184,7 +184,7 @@
 		}
 
 		// in group chats always append highlighted messages to queue
-		appendMessageEvent = appendMessageEvent && !d->queueOnlyHighlightedMessagesInGroupChats || manager->members().count() == 1 || msg.importance() == Kopete::Message::Highlight;
+		appendMessageEvent = appendMessageEvent && (!d->queueOnlyHighlightedMessagesInGroupChats || manager->members().count() == 1 || msg.importance() == Kopete::Message::Highlight);
 
 		if( appendMessageEvent )
 		{

Comment 2 Jan Ritzerfeld 2006-04-21 16:58:08 UTC

SVN commit 532285 by jritzerfeld:

Fixed missing parentheses introduced in revision 532113.

BUG: 126016

 M  +2 -2      kopeteviewmanager.cpp  


--- branches/KDE/3.5/kdenetwork/kopete/libkopete/private/kopeteviewmanager.cpp #532284:532285
@@ -175,7 +175,7 @@
 			// append msg event to queue if chat window is active but not the chat view in it...
 			appendMessageEvent = appendMessageEvent && !(w->isActiveWindow() && manager->view() == d->activeView);
 			// ...and chat window is on another desktop
-			appendMessageEvent = appendMessageEvent && !d->queueOnlyMessagesOnAnotherDesktop || !KWin::windowInfo( w->topLevelWidget()->winId(), NET::WMDesktop ).isOnCurrentDesktop();
+			appendMessageEvent = appendMessageEvent && (!d->queueOnlyMessagesOnAnotherDesktop || !KWin::windowInfo( w->topLevelWidget()->winId(), NET::WMDesktop ).isOnCurrentDesktop());
 		}
 		else
 		{
@@ -184,7 +184,7 @@
 		}
 
 		// in group chats always append highlighted messages to queue
-		appendMessageEvent = appendMessageEvent && !d->queueOnlyHighlightedMessagesInGroupChats || manager->members().count() == 1 || msg.importance() == Kopete::Message::Highlight;
+		appendMessageEvent = appendMessageEvent && (!d->queueOnlyHighlightedMessagesInGroupChats || manager->members().count() == 1 || msg.importance() == Kopete::Message::Highlight);
 
 		if( appendMessageEvent )
 		{