Bug 125373

Summary:	Tab color reset back to black upon tab move
Product:	[Applications] konsole	Reporter:	Tomer Shalev <shalev.tomer>
Component:	general	Assignee:	Konsole Bugs <konsole-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.6
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Tomer Shalev 2006-04-11 16:29:32 UTC

Version:           1.6 (using KDE KDE 3.5.1)
Installed from:    Debian testing/unstable Packages
OS:                Linux

To reproduce:
1. Open multiple tabs.
2. Set costume color for one of the tabs (right click tab and select 'Select Tab Color...').
3. Select that tab as the active tab.
4. Move the tab to the right or to the left (Ctrl+Shift+Right/Left).

The color of the tab is reset back to black instead of staying the same.

Comment 1 Thorsten Roeder 2006-04-30 18:22:36 UTC

SVN commit 535863 by troeder:

remember the color of the tab while moving the tab.
CCBUG: 125373


 M  +8 -2      konsole.cpp  


--- trunk/KDE/kdebase/apps/konsole/konsole/konsole.cpp #535862:535863
@@ -3072,12 +3072,15 @@
   ra->unplug(m_view);
   ra->plug(m_view,(m_view->count()-sessions.count()+1)+position-1);
 
+  QColor oldcolor = tabwidget->tabTextColor(tabwidget->indexOf(se->widget()));
+  
   tabwidget->blockSignals(true);
   tabwidget->removePage(se->widget());
   tabwidget->blockSignals(false);
   createSessionTab(se->widget(), iconSetForSession(se), se->Title(), position-1);
   tabwidget->showPage(se->widget());
-
+  tabwidget->setTabTextColor(tabwidget->indexOf(se->widget()),oldcolor);
+  
   if (!m_menuCreated)
     makeGUI();
   m_moveSessionLeft->setEnabled(position-1>0);
@@ -3100,12 +3103,15 @@
   ra->unplug(m_view);
   ra->plug(m_view,(m_view->count()-sessions.count()+1)+position+1);
 
+  QColor oldcolor = tabwidget->tabTextColor(tabwidget->indexOf(se->widget()));
+  
   tabwidget->blockSignals(true);
   tabwidget->removePage(se->widget());
   tabwidget->blockSignals(false);
   createSessionTab(se->widget(), iconSetForSession(se), se->Title(), position+1);
   tabwidget->showPage(se->widget());
-
+  tabwidget->setTabTextColor(tabwidget->indexOf(se->widget()),oldcolor);
+  
   if (!m_menuCreated)
     makeGUI();
   m_moveSessionLeft->setEnabled(true);

Comment 2 Thorsten Roeder 2006-05-02 00:23:57 UTC

This bug is fixed in the next release.
Thank you for reporting.

Comment 3 Pg 2006-05-17 10:22:38 UTC

Hi, 
I'm afraid to tell you, but there's the same problem in version
1.6.2 (using KDE 3.5.2 (unstable)) :-(
[or with next version you mean 1.7?]

Comment 4 Kurt Hindenburg 2006-05-17 16:15:21 UTC

Fix in KDE 3.5.3 which will be released this month.