Bug 124985

Summary:	Legend drawing artefacts between text and border
Product:	[Applications] kst	Reporter:	Nicolas Brisset <nicolas.brisset>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.x
Target Milestone:	---
Platform:	unspecified
OS:	Solaris
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Example kst file to use with test.dat just attached to bug #128436 The way the "new" kst stores the same thing

Description Nicolas Brisset 2006-04-05 17:33:14 UTC

Version:           1.3.0_devel (using KDE 3.4.0, compiled sources)
Compiler:          gcc version 3.4.3
OS:                SunOS (sun4u) release 5.8

In my setup (today's svn), legends exhibit drawing artefacts in the area between text and border. The rectangle around the text has the solid background color, but it seems is does not extend far enough to reach the border. I will attach a screenshot to make it clearer. As soon as another window or a menu covers the legend, it leaves traces behind. And if grids are used, they can be seen in the interval as well.

Comment 1 Nicolas Brisset 2006-04-05 17:34:35 UTC

Created attachment 15479 [details]
Example

Comment 2 Andrew Walker 2006-05-08 19:39:20 UTC

I'm unable to reproduce this. Nicolas, would you mind checking this is still a problem with the latest version of the code. Thanks.

Comment 3 Nicolas Brisset 2006-05-11 18:01:36 UTC

Well, I can't reproduce it. It must have been fixed somehow, I'll close the bug for now.

Comment 4 Nicolas Brisset 2006-06-01 12:48:00 UTC

Well, actually it seems the problem appears when loading "old" kst files with a newer kst version. I'll attach a test case shortly :-)

Comment 5 Nicolas Brisset 2006-06-01 12:55:21 UTC

Created attachment 16399 [details]
kst file to use with test.dat just attached to bug #128436

Try to reload the .kst file with kst from svn: the artefacts are visible. This
.kst was generated with an older version (1.2.0_devel) of kst. 
By the way, it would be cool if the "About kst..." dialog showed the svn
revision number along with the human-readable one, unless there is a way to
find it elsewhere when you don't remember from which of the many extragear
copies you have lying around the installed version comes :-)

Comment 6 Nicolas Brisset 2006-06-01 12:56:40 UTC

Created attachment 16400 [details]
The way the "new" kst stores the same thing

Looking at the .kst files, there are differences indeed. So, basically, this is
a lack of upward compatibility...

Comment 7 Andrew Walker 2006-06-01 19:47:48 UTC

SVN commit 547320 by arwalker:

BUG:124985 In the old kst file the padding was set to 5. The padding should always be zero for this object.

 M  +2 -0      kstviewlegend.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kstviewlegend.cpp #547319:547320
@@ -124,6 +124,8 @@
       addCurve(*it);
     }
   }
+  
+  setPadding(0);
 }