| Summary: | Allow to turn off Presentation tool delay [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Marcus Popp <marcus.popp> |
| Component: | Plugin-Generic-Presentation | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, metzpinguin, phuockhanhnk94, sambhavdusad24 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 7.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/digikam/commit/62c281789a4e174001e5778ce1407d38eb5c50ad | Version Fixed In: | 7.2.0 |
| Sentry Crash Report: | |||
| Attachments: |
Solves the #124788 entry.
AutoDelay2.patch Solves the #124788 entry. resolution for bug of presentation in mode normal (not in openGL mode) disable OpenGL when activate offAutoDelay |
||
|
Description
Marcus Popp
2006-04-02 21:27:16 UTC
Marcus, It stil valid using kipi-plugins 2.4 ? Gilles Caulier Created attachment 119244 [details]
Solves the #124788 entry.
This patch gives the user option to switch off the Auto Delay option in Advanced Slideshow.
The user has to check the Off Auto Delay checkbox. After Checking this, the effects will be turned off and user can traverse the slideshow using the mouse|pagedown|cursor|space.
Sambhav
Created attachment 119246 [details]
AutoDelay2.patch
Patch adapted to current git/master.
Maik
- bool offAutoDelay is not initialized - not implemented in OpenGL mode - after the left click the control widget stays permanently on Maik We can fix this easier. If the presentation is in pause mode, only the overlays should not be permanently displayed. Maik Created attachment 119366 [details]
Solves the #124788 entry.
Implementation in OpenGL mode done.
offAutoDelay initialized.
SlideCtrlWidget now does not stays on.
But when the presentation is not in OpenGL mode and the user starts the presentation and when I hover over the ctrl widget, the patch of the widget which overlaps with the image shows the previous image in image list.
I wasn't able to find a way to resolve this.
Sambhav
Maik, I assigned too this file to Phuoc Khanh LE for review and fix. Gilles Created attachment 135378 [details]
resolution for bug of presentation in mode normal (not in openGL mode)
The reason of the overlaps is that the function QPaintEvent() is called automatically after Constructor of class PresentationWidget. Therefor, they display the buffer instead of d->currImage. This patch inserts m_firstPainter which is initialized by true to passe theses first paintEvents(s). This variable is turn to false in the first loadNextImage().
LE
Thanks Le for the patch. Didi you plan to apply the same fix for OpenGL mode ? Best Gilles I apply the patch of Sambhav, and it made the bug only on mode normal. I made some try on mode OpenGL and there is no bug. LE Thanks Le for the patch. I tested all changes and it work like expected. 2 remarks: - off auto delay option must disable OpenGL effect, as OpenGl require a transition. This is no sense to lets OpenGL available if this option is activated. - In presentation_mainpage.ui, the waht's this text to describe off auto delay option must be simple text, as this string will be processed by translators team. Description from you patch is this one: <string><html><head/><body><p>Removes the auto-delay between images.</p></body></html></string> Also i recommend to be more verbose here, aka this option requires user action to switch between images. I'm waiting a new patch with this tunes. Thanks in advance Gilles Created attachment 135527 [details]
disable OpenGL when activate offAutoDelay
This patch will disable OpenGL automatically by activating offAutoDelay. The description of offAutoDelay in presentation_mainpage.ui is also corrected in this patch.
LE
Git commit 62c281789a4e174001e5778ce1407d38eb5c50ad by Gilles Caulier. Committed on 09/02/2021 at 14:51. Pushed by cgilles into branch 'master'. Apply patch #135527 from Phuoc Khanh LE to allow to turn off Presentation tool delay between image FIXED-IN: 7.2.0 M +4 -3 core/dplugins/generic/view/presentation/audio/presentation_audiopage.cpp M +4 -2 core/dplugins/generic/view/presentation/audio/presentation_audiopage.h M +1 -1 core/dplugins/generic/view/presentation/audio/presentationaudiolist.cpp M +2 -1 core/dplugins/generic/view/presentation/audio/presentationaudiolist.h M +7 -7 core/dplugins/generic/view/presentation/audio/presentationaudiowidget.cpp M +3 -1 core/dplugins/generic/view/presentation/audio/presentationaudiowidget.h M +36 -33 core/dplugins/generic/view/presentation/common/presentationcontainer.cpp M +1 -0 core/dplugins/generic/view/presentation/common/presentationcontainer.h M +16 -14 core/dplugins/generic/view/presentation/common/presentationloader.cpp M +11 -1 core/dplugins/generic/view/presentation/dialogs/presentation_advpage.cpp M +2 -1 core/dplugins/generic/view/presentation/dialogs/presentation_advpage.h M +2 -1 core/dplugins/generic/view/presentation/dialogs/presentation_captionpage.cpp M +2 -1 core/dplugins/generic/view/presentation/dialogs/presentation_captionpage.h M +54 -4 core/dplugins/generic/view/presentation/dialogs/presentation_mainpage.cpp M +3 -1 core/dplugins/generic/view/presentation/dialogs/presentation_mainpage.h M +10 -0 core/dplugins/generic/view/presentation/dialogs/presentation_mainpage.ui M +18 -6 core/dplugins/generic/view/presentation/dialogs/presentationdlg.cpp M +2 -1 core/dplugins/generic/view/presentation/dialogs/presentationdlg.h M +12 -2 core/dplugins/generic/view/presentation/opengl/presentationgl.cpp M +1 -1 core/dplugins/generic/view/presentation/presentationplugin.cpp M +43 -17 core/dplugins/generic/view/presentation/widgets/presentationwidget.cpp M +1 -0 core/dplugins/generic/view/presentation/widgets/presentationwidget.h https://invent.kde.org/graphics/digikam/commit/62c281789a4e174001e5778ce1407d38eb5c50ad |