Summary: | kdelibs 3.5.2 - Compile error on Solaris 8: duplicate extern | ||
---|---|---|---|
Product: | [Unmaintained] kdelibs | Reporter: | Steve Evans <stevee> |
Component: | general | Assignee: | Stephan Kulow <coolo> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Solaris | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Steve Evans
2006-03-28 13:07:46 UTC
Same here, using the same patch works for me as well. This is a rest from https://bugs.kde.org/show_bug.cgi?id=114747 I can confirm this. Compiling KDE 3.5.2 on Solaris 9 using gcc 3.4.5 gives: In file included from libkdecore_la.all_cpp.cpp:72: ksycoca.cpp: At global scope: ksycoca.cpp:46: error: duplicate `extern' Stephan's change fixes this. NOTE: The wrong code also exists in the current trunk not just the 3.5 branch. *** kdelibs-3.5.2/kdecore/ksycoca.cpp Fri Mar 17 21:19:04 2006 --- kdelibs/kdecore/ksycoca.cpp Wed Mar 29 11:22:59 2006 *************** *** 43,49 **** #endif #ifdef Q_OS_SOLARIS ! extern "C" extern int madvise(caddr_t, size_t, int); #endif #ifndef MAP_FAILED --- 43,49 ---- #endif #ifdef Q_OS_SOLARIS ! extern "C" int madvise(caddr_t, size_t, int); #endif #ifndef MAP_FAILED Still not fixed in kdelibs-3.5.3 SVN commit 550555 by adridg: Resolve duplicate externs. Bernd (someone with Solaris) please test. BUG: 124416 BUG: 114747 CCMAIL: bernd.kuhls@informatik.uni-oldenburg.de M +4 -1 ksycoca.cpp --- branches/KDE/3.5/kdelibs/kdecore/ksycoca.cpp #550554:550555 @@ -43,7 +43,10 @@ #endif #ifdef Q_OS_SOLARIS -extern "C" extern int madvise(caddr_t, size_t, int); +extern "C" +{ + extern int madvise(caddr_t, size_t, int); +} #endif #ifndef MAP_FAILED That change fixes the compile problem for me. On Solaris 8, gcc 3.4.6 |