Bug 124336

Summary:	inconsistency: text of symlinks on the desktop is not shown in italic font
Product:	[Unmaintained] kdesktop	Reporter:	Janet <bugzilla>
Component:	general	Assignee:	David Faure <faure>
Status:	CLOSED FIXED
Severity:	normal	CC:	finex
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Janet 2006-03-27 01:06:29 UTC

Version:            (using KDE KDE 3.5.1)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Contrary to the appearance of symlinks everywhere else, on the desktop they appear in normal font, not italic. That's inconsistent and you can only distinguish between files/folders that really are located on the desktop and symlinks of files when you look into the properties. I accidentially deleted some files and folders for I thought they were just symlinks. Also the little arrow for symlinks isn't shown anymore.

Comment 1 Martin Koller 2006-11-01 21:19:31 UTC

Symlinks are only shown in italic in konqueror when using icon-view mode (in detail, tree, text mode it's not). So it's inconsistent everywhere ;-)

Also, when I create a symlink on the desktop, I still get the Icon with the little arrow (KDE-3.5.5)
Probably you use some other settings (I don't know which influence this)...

Can you check with different settings where exactly you see this problem with the arrows ?

Comment 2 Janet 2006-11-03 16:10:55 UTC

The problem with the arrow: it is shown if the icon used for the linked file/folder is available in the size set for the icons on the desktop. It is not shown if the icon used is only available in bigger or smaller size and therefore is scaled.

> Symlinks are only shown in italic in konqueror when using icon-view mode (in detail, tree, text mode it's not). So it's inconsistent everywhere ;-) 

I agree ;) And I really would prefer if symlinks were displayed in italic font in every view mode. But it really should be consistent within one mode - and to me the icon-view mode of the konq filemanager and the icons on the desktop are the same mode.

Comment 3 David Faure 2006-11-03 21:19:50 UTC

That's a bug actually - a regression from the "drawing text with a shadow on the desktop" code. I'll look into it.

Comment 4 David Faure 2006-11-03 21:22:37 UTC

SVN commit 601595 by dfaure:

Use italic font again for symlinks on the desktop; regression introduced by the paint-text-with-shadow code.
BUG: 124336


 M  +4 -2      kfileividesktop.cpp  


--- branches/KDE/3.5/kdebase/kdesktop/kfileividesktop.cpp #601594:601595
@@ -86,7 +86,6 @@
 void KFileIVIDesktop::paintItem( QPainter *p, const QColorGroup &cg)
 {
   QColorGroup colors = updateColors(cg);
-  paintFontUpdate(p);
 
   QIconView* view = iconView();
   Q_ASSERT( view );
@@ -107,8 +106,10 @@
   //
   if (m_shadow != 0L && (static_cast<KDesktopShadowSettings *> (m_shadow->shadowSettings()))->isEnabled())
     drawShadowedText(p, colors);
-  else
+  else {
+    paintFontUpdate(p);
     paintText(p, colors);
+  }
 
   p->restore();
 
@@ -177,6 +178,7 @@
   unsigned long uid = settings->UID();
 
   p->setFont(iconView()->font());
+  paintFontUpdate(p);
   QColor shadow;
   QColor text;
   int spread = shadowThickness();

Comment 5 David Faure 2006-11-03 21:28:51 UTC

BTW KDE4 will use the same itemdelegate for all view modes, so they will be much more consistent.

Comment 6 FiNeX 2009-01-02 20:32:26 UTC

Bug closed. Kdesktop is no more mantained.