Bug 124265

Summary:	User Limit in Channel Options Dialog broken
Product:	[Applications] konversation	Reporter:	Sebastian Wiedenroth <wiedi>
Component:	general	Assignee:	Konversation Bugs <konversation-bugs-null>
Status:	CLOSED WORKSFORME
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Sebastian Wiedenroth 2006-03-26 00:41:18 UTC

Version:           0.19+ Build 3102 (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc version 3.4.4 
OS:                Linux

Enabling / disabling or changing the "User limit" mode in the "Channel Options" Dialog does not work correctly.

The raw log shows some strange things:

increasing user limit (was set previously):
[00:07:53] << MODE #test2 +K onversation::ChannelOptionsDialog
returns a log of 472s "unknown mode char"

decreasinguser limit:
[00:12:21] << MODE #test2 +k
[00:12:21] >> :irc.server 461 Nick MODE +k :Not enough parameters

disabling user limit:
[00:13:14] << MODE #test2 -

enabling user limit:
does nothing

try on an other channel+computer (there with konvi 0.19 #3100 on fbsd)

enabling user limit:
<< MODE #test +d get

increasing user limit:
MODE #test +h owOSD

decreasing:
<< MODE #test +D Widget

disabling:
<< TOPIC #test
>> :irc.server 331 nick #test :No topic is set.
<< MODE #test -t
>> nick!bla@blub MODE #test -t


Typing /mode by hand or using the "channel mode buttons" works fine.
For more information just contact me. ;-)

Comment 1 Shintaro Matsuoka 2006-05-18 09:10:07 UTC

SVN commit 542070 by shin:

Fix the problem that "User Limit" in Channel Option Dialog doesn't work correctly.

Thank you for the report. Please confirm this fix.
CCBUG: 124265

 M  +1 -1      channeloptionsdialog.cpp  


--- trunk/extragear/network/konversation/src/channeloptionsdialog.cpp #542069:542070
@@ -321,7 +321,7 @@
         mode += "n";
         modes.append(mode);
         mode = (m_widget->userLimitChBox->isChecked() ? "+" : "-");
-        mode += "l" + m_widget->userLimitEdit->value();
+        mode += "l" + QString::number( m_widget->userLimitEdit->value() );
         modes.append(mode);
         mode = (m_widget->inviteModeChBox->isChecked() ? "+" : "-");
         mode += "i";

Comment 2 Sebastian Wiedenroth 2006-05-18 12:31:37 UTC

thanks, works perfect now ;-)