Bug 124232

Summary:	monthly recurrence defaults are wrong when recurring by day
Product:	[Applications] korganizer	Reporter:	mecrider
Component:	general	Assignee:	Reinhold Kainhofer <reinhold>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	3.5
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description mecrider 2006-03-25 14:55:57 UTC

Version:           3.5 (using KDE KDE 3.5.1)
OS:                Linux

Steps to reproduce: Create a new event (for example, on Tuesday, March 28, 2006). On the recurrence tab, enable recurrence, and mark the monthly recurrence rule. The default recurrence by day is the 4th Monday, when it should be the 4th Tuesday.
Extra information that might be pertinant: I have my weeks start on Sunday instead of the normal Monday in KDE's date preferences.

Comment 1 Yuriy Kozlov 2006-05-18 21:27:59 UTC

I can confirm this on up to date kubuntu dapper with KDE 3.5.2. The default day for the monthly recurrance is always the day before it should be.

Comment 2 Reinhold Kainhofer 2006-05-21 10:18:43 UTC

Fixed by this commit by Will (and the forward-port by Allen):

Am Donnerstag, 18. Mai 2006 17:42 schrieb Will Stephenson:
> SVN commit 542207 by wstephens:
>
> Get the day right.
>
>
>  M  +1 -1      koeditorrecurrence.cpp  
>
>
> --- branches/KDE/3.5/kdepim/korganizer/koeditorrecurrence.cpp
> #542206:542207 @@ -1165,7 +1165,7 @@
>    mWeekly->setDays( days );
>  
>    mMonthly->setFrequency( 1 );
> -  mMonthly->setByPos( ( from.date().day() - 1 ) / 7 + 1, 
>    from.date().dayOfWeek() - 1 );  
> +  mMonthly->setByPos( ( from.date().day() - 
> 1 ) / 7 + 1, from.date().dayOfWeek() ); 
>    mMonthly->setByDay( from.date().day() );
>  
>    mYearly->setFrequency( 1 );