Bug 123538

Summary: [WISH] add timezone search for kcontrol clock module.
Product: [Unmaintained] kcontrol Reporter: cjacker <cjacker>
Component: kcmclockAssignee: Paul Campbell <paul>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description cjacker 2006-03-13 05:48:46 UTC
Version:            (using KDE KDE 3.5.1)
Installed from:    Compiled From Sources

now, kde use KTimezoneWidget to show timezone list.

but the list is to long, if i want to config the default timezone, it is very difficult for me to find the
corrent one.

so add a search filter in kcmshell clock will be better.

kde had provide a Class named:KListViewSearchLine
here is my test code, it really make it easy to find timezone which i need.


diff -Nur kdebase-3.5.1/kcontrol/clock/tzone.cpp kdebase-3.5.1new/kcontrol/clock/tzone.cpp
--- kdebase-3.5.1/kcontrol/clock/tzone.cpp  2006-01-19 12:00:53.000000000 -0500
+++ kdebase-3.5.1new/kcontrol/clock/tzone.cpp   2006-03-12 21:53:39.039985224 -0500
@@ -45,13 +45,19 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #endif
-
+#include <klistviewsearchline.h>
+#include <qlayout.h>
 Tzone::Tzone(QWidget * parent, const char *name)
   : QVGroupBox(parent, name)
 {
     setTitle(i18n("To change the timezone, select your area from the list below"));

+
+    KListViewSearchLine * tzsearch = new KListViewSearchLine(this,"");
     tzonelist = new KTimezoneWidget(this, "ComboBox_1", &m_zoneDb);
+
+//    KListViewSearchLine * tzsearch = new KListViewSearchLine(this,tzonelist,"");
+   tzsearch->setListView(tzonelist);
     connect( tzonelist, SIGNAL(selectionChanged()), SLOT(handleZoneChange()) );

     m_local = new QLabel(this);
Comment 1 Harald Sitter 2010-04-06 22:45:53 UTC
SVN commit 1111865 by sitter:

Make timezone tab searchable via a KTreeWidgetSearchLine

BUG: 123538


 M  +17 -15    dateandtime.ui  
 M  +2 -0      dtime.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1111865
Comment 2 Harald Sitter 2010-04-07 11:24:36 UTC
SVN commit 1112074 by sitter:

Backporting r1111779, r1111783, r1111865, r1111878 and r1111886

* Make ntpUtility lookup code work properly (fullpath lookup) and streamline it a bit
* Cleanup helper
* Pass ntpUtility found in dtime to helper instead of looking it up again
* Ensure kcmclockrc is world readable to make sure it can be read later on
This makes the KCM save the NTP config properly AND makes the NTP settings actually apply \o/
* Lock widget before invoking auth, to prevent problems from occuring... the KCM controls however do not quite follow my orders and stay active :(
* Make timezone tab searchable via a KTreeWidgetSearchLine
* Insert timezones4 catalog for KTimeZoneWidget::displayName
* Fix timezone changes

BUG: 123538
BUG: 148890
BUG: 148790



 M  +17 -0     dateandtime.ui  
 M  +10 -11    dtime.cpp  
 M  +12 -15    helper.cpp  
 M  +2 -1      helper.h  
 M  +10 -0     main.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1112074