| Summary: | ntp server list should not be able to translate | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | cjacker <cjacker> |
| Component: | kcm_clock | Assignee: | Paul Campbell <paul> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | normal | CC: | andresbajotierra, jpwhiting, kde, molkentin |
| Priority: | NOR | Flags: | jpwhiting:
gardening+
|
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
I don't agree. The i18n should be changed to notify translators to use commas and not whatever separator they use for their language. I am afraid that it give a chance to somebody to make things wrong. here, it provides a url list defaultly, there is no need to translate the url to other languages. Why not using :
i18n("Public Time Server (pool.ntp.org)") + "ip1,ip2,ip3" ?
The last ones aren't translated at all, they are URLs. I'm also wondering if KConfig can handle (string)lists now, so the list could be loaded and splitted by KConfig itself. (In KDE4 I can't see any UI to save manually added servers...) So the problem could be converting the old saved (in KDE3?) ntp server list to a new format.
Regards
We no longer have UI visible NTP server lists. |
Version: (using KDE KDE 3.5.1) Installed from: Compiled From Sources ntp server list in kcontrol/clock/dtime.cpp had been marked as I18n string. that is to say, user can translate it to other language. But, the code in dtime.cpp use "," to separate the server list. after locale translation, may be , the "," will be translate to other letter, for example, in chinese, it will be translate to “，”, then , the split function will not work. so, I think, we should remove the i18n mark here. the patch is like this: diff -Nur kdebase-3.5.1/kcontrol/clock/dtime.cpp kdebase-3.5.1new/kcontrol/clock/dtime.cpp --- kdebase-3.5.1/kcontrol/clock/dtime.cpp 2005-10-10 11:03:48.000000000 -0400 +++ kdebase-3.5.1new/kcontrol/clock/dtime.cpp 2006-03-12 21:53:31.044200768 -0500 @@ -243,11 +243,11 @@ KConfig config("kcmclockrc", true, false); config.setGroup("NTP"); timeServerList->insertStringList(QStringList::split(',', config.readEntry("servers", - i18n("Public Time Server (pool.ntp.org),\ + "pool.ntp.org,\ asia.pool.ntp.org,\ europe.pool.ntp.org,\ north-america.pool.ntp.org,\ -oceania.pool.ntp.org")))); +oceania.pool.ntp.org"))); setDateTimeAuto->setChecked(config.readBoolEntry("enabled", false)); // Reset to the current date and time