| Summary: | Implement setting of ICQ default encoding | ||
|---|---|---|---|
| Product: | [Unmaintained] kopete | Reporter: | Bartosz Fabianowski <freebsd> |
| Component: | ICQ and AIM Plugins | Assignee: | Kopete Developers <kopete-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | baum-im-wald |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Attaching a screenshot as requested in bug 124431.
Here comes patch to enable account encoding selection. |
||
|
Description
Bartosz Fabianowski
2006-03-12 13:13:13 UTC
*** Bug 124431 has been marked as a duplicate of this bug. *** I hope it's ok to move this from a wishlist item to a normal bug. There is a combo for selecting the default encoding and it's always grayed out. This is clearly a defect. Also, the potential impact on users is very high as accented characters in any encoding other than Big5 are getting mingled by default. For more details on what the lack of a default encoding selection leads to, see comment #2 in bug 124431. Created attachment 15428 [details] Attaching a screenshot as requested in bug 124431. I noticed those bad characters not only in awaymessages but also in chats (seems to be an overall problem of OSCAR related stuff as stated above). please fix this for 0.12 final , i sometimes really have to guess, what the other person in the chat has written, if german-umlauts are used. in bug 124431 there is a comment with a workaround for single contacts, this will solve for me until 0.12 final Created attachment 15616 [details]
Here comes patch to enable account encoding selection.
This patch is quite trivial. It enables account encoding selection and adds one
more choice to contact encoding: default one. If default encoding is selected
for contact, contactEncoding property is unset, and account encoding is used
for the contact.
I have KDE Subversion account. Commit this change?
I haven't tried compiling with your patch yet, but I am wondering: You haven't changed the defaults anywhere. What will happen if a user does not set the encoding anywhere. What will it default to? Sorry, I've forgot to mention that my patch also changes default for account encoding from the first in the list (Big5) to ISO8859-1. Not a best solution (for example, for Russian users Windows-1251 would be much better), but I don't know the clear way to determine user's default language and translate in to Windows codepage name. The default for contact encoding remains the same: to have no contactEncoding property and hence to use account encoding. The difference is that this case is mentioned in contact encoding menu explicitly. So, does anyone have objections against committing changes described in patch 15616 and thus effectively closing this bug? please commit so, has this been committed yet? Yes, it was committed (revision 530560), but something strange happened. Despite I've added the line "BUG: 123486" in commit message, nothing happened. The status of this bug did not change. Did I do something wrong? iirc, that happened to me the first time too, because I didn't have permission to close bugs. I'll close this one for you and hopefully someone with more authority can sort things out. :) |